style(*): wrap all assignments in if statements

we commonly assign stuff in if statments like this:

if (variable = someFn()) {
  //do something with variable
}

This results in lint and IDE warnings (did you mean ==?).

It is better to be explicit about our intention and wrap the assignement
into parens:

if ((variable = someFn())) {
  //do something with variable
}

Doing so suppresses warnings + is easier to understand the intention.

I verified that the closure compiler strips the extra parens, so there
is no byte overhead for this safety practice.

We should use this style going forward...

1 files changed, 2 insertions, 2 deletions

diff --git a/src/Scope.js b/src/Scope.js
index b50d6273..6e90ea66 100644
--- a/src/Scope.js
+++ b/src/Scope.js
@@ -343,7 +343,7 @@ Scope.prototype = {
             scope.$service('$exceptionHandler')(e);
           }
         }
-        if (watchers = scope.$$watchers) {
+        if ((watchers = scope.$$watchers)) {
           // process our watches
           length = watchers.length;
           while (length--) {
@@ -372,7 +372,7 @@ Scope.prototype = {
             }
           } while (scope !== this);
         }
-      } while (scope = next);
+      } while ((scope = next));
 
       if(!(ttl--)) {
         throw Error('100 $digest() iterations reached. Aborting!');