diff options
| author | Peter Bacon Darwin | 2013-10-05 10:49:09 +0100 |
|---|---|---|
| committer | Vojta Jina | 2013-10-07 09:01:13 -0700 |
| commit | 7a586e5c19f3d1ecc3fefef084ce992072ee7f60 (patch) | |
| tree | 2690c915adb20d92a065d9ad9d7438766d4620f8 /docs | |
| parent | fb99f542060d3959d273634c90889788861b5c05 (diff) | |
| download | angular.js-7a586e5c19f3d1ecc3fefef084ce992072ee7f60.tar.bz2 | |
fix(*): protect calls to hasOwnProperty in public API
Objects received from outside AngularJS may have had their `hasOwnProperty`
method overridden with something else. In cases where we can do this without
incurring a performance penalty we call directly on Object.prototype.hasOwnProperty
to ensure that we use the correct method.
Also, we have some internal hash objects, where the keys for the map are provided
from outside AngularJS. In such cases we either prevent `hasOwnProperty` from
being used as a key or provide some other way of preventing our objects from
having their `hasOwnProperty` overridden.
BREAKING CHANGE: Inputs with name equal to "hasOwnProperty" are not allowed inside
form or ngForm directives.
Before, inputs whose name was "hasOwnProperty" were quietly ignored and not added
to the scope. Now a badname exception is thrown.
Using "hasOwnProperty" for an input name would be very unusual and bad practice.
Either do not include such an input in a `form` or `ngForm` directive or change
the name of the input.
Closes #3331
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/content/error/ng/badname.ngdoc | 8 | ||||
| -rw-r--r-- | docs/content/error/resource/badname.ngdoc | 8 |
2 files changed, 16 insertions, 0 deletions
diff --git a/docs/content/error/ng/badname.ngdoc b/docs/content/error/ng/badname.ngdoc new file mode 100644 index 00000000..5d3a6f61 --- /dev/null +++ b/docs/content/error/ng/badname.ngdoc @@ -0,0 +1,8 @@ +@ngdoc error +@name ng:badname +@fullName Bad `hasOwnProperty` Name +@description + +Occurs when you try to use the name `hasOwnProperty` in a context where it is not allow. +Generally, a name cannot be `hasOwnProperty` because it is used, internally, on a object +and allowing such a name would break lookups on this object.
\ No newline at end of file diff --git a/docs/content/error/resource/badname.ngdoc b/docs/content/error/resource/badname.ngdoc new file mode 100644 index 00000000..99f73bdc --- /dev/null +++ b/docs/content/error/resource/badname.ngdoc @@ -0,0 +1,8 @@ +@ngdoc error +@name $resource:badname +@fullName Cannot use hasOwnProperty as a parameter name +@description + +Occurs when you try to use the name `hasOwnProperty` as a name of a parameter. +Generally, a name cannot be `hasOwnProperty` because it is used, internally, on a object +and allowing such a name would break lookups on this object.
\ No newline at end of file |