diff options
| author | J Bruni | 2013-10-08 00:09:06 -0300 | 
|---|---|---|
| committer | Pete Bacon Darwin | 2013-10-08 12:59:46 +0100 | 
| commit | f7fc00841bf5e3ffa2d9c2b1d316ed4dcdcde756 (patch) | |
| tree | 0a938ea410c8d1eff99fbe7fd3b2e4206afb2352 | |
| parent | 507d8021b1c91cc0cefc0418e61b04597ad1030b (diff) | |
| download | angular.js-f7fc00841bf5e3ffa2d9c2b1d316ed4dcdcde756.tar.bz2 | |
docs(cookbook/adv_forms): simplify example
Pass the `$index` directly to the `removeContact` function, instead of
searching for it in an expensive forEach loop.
Closes #4320
| -rw-r--r-- | docs/content/cookbook/advancedform.ngdoc | 11 | 
1 files changed, 3 insertions, 8 deletions
| diff --git a/docs/content/cookbook/advancedform.ngdoc b/docs/content/cookbook/advancedform.ngdoc index 1501f955..bcf8069a 100644 --- a/docs/content/cookbook/advancedform.ngdoc +++ b/docs/content/cookbook/advancedform.ngdoc @@ -38,13 +38,8 @@ detection, and preventing invalid form submission.         $scope.form.contacts.push({type:'', value:''});       }; -     $scope.removeContact = function(contact) { -       var contacts = $scope.form.contacts; -       for (var i = 0, ii = contacts.length; i < ii; i++) { -         if (contact === contacts[i]) { -           contacts.splice(i, 1); -         } -       } +     $scope.removeContact = function(index) { +       $scope.form.contacts.splice(index, 1);       };       $scope.isCancelDisabled = function() { @@ -83,7 +78,7 @@ detection, and preventing invalid form submission.             <option>IM</option>           </select>           <input type="text" ng-model="contact.value" required/> -          [ <a href="" ng-click="removeContact(contact)">X</a> ] +          [ <a href="" ng-click="removeContact($index)">X</a> ]         </div>       <button ng-click="cancel()" ng-disabled="isCancelDisabled()">Cancel</button>       <button ng-click="save()" ng-disabled="isSaveDisabled()">Save</button> | 
