diff options
| author | metaweta | 2013-01-29 11:30:12 -0800 |
|---|---|---|
| committer | Igor Minar | 2013-01-29 13:24:33 -0800 |
| commit | e4cfb9d938c1d9cd08942d3192c281e16d2c200d (patch) | |
| tree | 0f8adc305cfcaa77b64a5c1748ebe912a215ba8d | |
| parent | 87ba8221ec55ad3e781a1726e85275ae50c1571e (diff) | |
| download | angular.js-e4cfb9d938c1d9cd08942d3192c281e16d2c200d.tar.bz2 | |
refactor(Angular.js): prevent Error variable name leak in tests
Remove var Error = window.Error
window.Error is a read-only property in Apps Script.
Igor says, "we should just delete that line instead. I think it was
misko's attempt to get better closure minification, but it turns out
that it's actually hurting us after gzip (I verified it)."
| -rw-r--r-- | src/Angular.js | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/Angular.js b/src/Angular.js index a7b3b98c..e6879586 100644 --- a/src/Angular.js +++ b/src/Angular.js @@ -49,8 +49,7 @@ if ('i' !== 'I'.toLowerCase()) { function fromCharCode(code) {return String.fromCharCode(code);} -var Error = window.Error, - /** holds major version number for IE or NaN for real browsers */ +var /** holds major version number for IE or NaN for real browsers */ msie = int((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1]), jqLite, // delay binding since jQuery could be loaded after us. jQuery, // delay binding |