aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIgor Minar2012-03-26 15:43:56 -0700
committerIgor Minar2012-03-26 15:43:59 -0700
commitaaedefb92e6bec6626e173e5155072c91471596a (patch)
treed6fb01b76c478e483849f839791497b3e9a64eb6
parentd54dfecb00fba41455536c5ddd55310592fdaf84 (diff)
downloadangular.js-aaedefb92e6bec6626e173e5155072c91471596a.tar.bz2
refactor($sniffer): make $sniffer service private
This service has been accidentaly documented in the past, it should not be considered to be public api. I'm also removing fallback to Modernizr since we don't need it. Breaks any app that depends on this service and its fallback to Modernizr, please migrate to custom "Modernizr" service: module.value('Modernizr', function() { return Modernizr; });
-rw-r--r--src/service/sniffer.js5
-rw-r--r--test/service/snifferSpec.js5
2 files changed, 2 insertions, 8 deletions
diff --git a/src/service/sniffer.js b/src/service/sniffer.js
index 4abe1fd2..eebb2903 100644
--- a/src/service/sniffer.js
+++ b/src/service/sniffer.js
@@ -1,7 +1,8 @@
'use strict';
/**
- * @ngdoc object
+ * !!! This is an undocumented "private" service !!!
+ *
* @name angular.module.ng.$sniffer
* @requires $window
*
@@ -13,8 +14,6 @@
*/
function $SnifferProvider(){
this.$get = ['$window', function($window){
- if ($window.Modernizr) return $window.Modernizr;
-
return {
history: !!($window.history && $window.history.pushState),
hashchange: 'onhashchange' in $window &&
diff --git a/test/service/snifferSpec.js b/test/service/snifferSpec.js
index 7ec1dc8d..b359e118 100644
--- a/test/service/snifferSpec.js
+++ b/test/service/snifferSpec.js
@@ -30,9 +30,4 @@ describe('$sniffer', function() {
expect(sniffer({onhashchange: true, document: {documentMode: 7}}).hashchange).toBe(false);
});
});
-
- it('should use Modernizr if defined', function() {
- var Modernizr = {};
- expect(sniffer({Modernizr: Modernizr})).toBe(Modernizr);
- });
});