diff options
| author | Igor Minar | 2011-01-31 23:22:12 -0800 |
|---|---|---|
| committer | Igor Minar | 2011-02-01 09:35:18 -0800 |
| commit | 9462c78fbf0896f0939c1bf3eb44a3f4f503f0a6 (patch) | |
| tree | db280a5c0d67f6e12377fddbe651ce314ff56795 | |
| parent | c4497d60bca23bd5d9176b3d09819d9e16d22862 (diff) | |
| download | angular.js-9462c78fbf0896f0939c1bf3eb44a3f4f503f0a6.tar.bz2 | |
$browser poller should notify $location only once per url change
| -rw-r--r-- | src/Browser.js | 1 | ||||
| -rw-r--r-- | src/angular-mocks.js | 1 | ||||
| -rw-r--r-- | test/BrowserSpecs.js | 5 |
3 files changed, 7 insertions, 0 deletions
diff --git a/src/Browser.js b/src/Browser.js index c67608cd..85bfb304 100644 --- a/src/Browser.js +++ b/src/Browser.js @@ -243,6 +243,7 @@ function Browser(window, document, body, XHR, $log) { self.addPollFn(function() { if (lastBrowserUrl != self.getUrl()) { listener(); + lastBrowserUrl = self.getUrl(); } }); } diff --git a/src/angular-mocks.js b/src/angular-mocks.js index fac411a9..fe0fb011 100644 --- a/src/angular-mocks.js +++ b/src/angular-mocks.js @@ -92,6 +92,7 @@ function MockBrowser() { function() { if (self.lastUrl != self.url) { listener(); + self.lastUrl == self.url } } ); diff --git a/test/BrowserSpecs.js b/test/BrowserSpecs.js index 1e5512b0..f0c026ba 100644 --- a/test/BrowserSpecs.js +++ b/test/BrowserSpecs.js @@ -358,6 +358,11 @@ describe('browser', function(){ expect(events).toEqual([]); browser.poll(); expect(events).toEqual(['x']); + + //don't do anything if url hasn't changed + events = []; + browser.poll(); + expect(events).toEqual([]); }); |
