aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIgor Minar2010-10-22 11:09:43 -0700
committerMisko Hevery2010-10-23 14:22:30 -0700
commit833e0ae343651a35ccce0940b048e0b5022adc7b (patch)
tree9fd2278589b425054cb30d6640c2c56e3417c236
parentd74ef497defa77c92873b09b7b6f4e19ae175779 (diff)
downloadangular.js-833e0ae343651a35ccce0940b048e0b5022adc7b.tar.bz2
$cookieStore should not be a global service
you must use $inject to $inject it as any other non-global service
-rw-r--r--CHANGELOG.md8
-rw-r--r--src/services.js2
-rw-r--r--test/servicesSpec.js6
3 files changed, 12 insertions, 4 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f12f9952..963deb34 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,11 @@
+# <angular/> 0.9.1 repulsion-field (in-progress) #
+
+### Breaking changes
+- $cookieStore service is not globally published any more, if you use it, you must request it via
+ $inject as any other non-global service
+
+
+
# <angular/> 0.9.0 dragon-breath (2010-10-20) #
### Security
diff --git a/src/services.js b/src/services.js
index 70d774a9..144f6177 100644
--- a/src/services.js
+++ b/src/services.js
@@ -641,4 +641,4 @@ angularServiceInject('$cookieStore', function($store) {
}
};
-}, ['$cookies'], EAGER_PUBLISHED);
+}, ['$cookies']);
diff --git a/test/servicesSpec.js b/test/servicesSpec.js
index a27abcc6..276f5de9 100644
--- a/test/servicesSpec.js
+++ b/test/servicesSpec.js
@@ -541,7 +541,7 @@ describe("service", function(){
describe('$cookieStore', function() {
it('should serialize objects to json', function() {
- scope.$cookieStore.put('objectCookie', {id: 123, name: 'blah'});
+ scope.$inject('$cookieStore').put('objectCookie', {id: 123, name: 'blah'});
scope.$eval(); //force eval in test
expect($browser.cookies()).toEqual({'objectCookie': '{"id":123,"name":"blah"}'});
});
@@ -550,12 +550,12 @@ describe("service", function(){
it('should deserialize json to object', function() {
$browser.cookies('objectCookie', '{"id":123,"name":"blah"}');
$browser.poll();
- expect(scope.$cookieStore.get('objectCookie')).toEqual({id: 123, name: 'blah'});
+ expect(scope.$inject('$cookieStore').get('objectCookie')).toEqual({id: 123, name: 'blah'});
});
it('should delete objects from the store when remove is called', function() {
- scope.$cookieStore.put('gonner', { "I'll":"Be Back"});
+ scope.$inject('$cookieStore').put('gonner', { "I'll":"Be Back"});
scope.$eval(); //force eval in test
expect($browser.cookies()).toEqual({'gonner': '{"I\'ll":"Be Back"}'});
});