aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFredrik Bonander2013-01-23 10:53:49 +0100
committerMisko Hevery2013-02-14 14:43:31 -0800
commit6194e002e2f8860218076a7a5ecf945b0d981843 (patch)
tree3ac736f09c690ee844a8b56dfde8a7b823627f04
parent75545d4d1c59192d781bb23d8bd2f72c9be37d38 (diff)
downloadangular.js-6194e002e2f8860218076a7a5ecf945b0d981843.tar.bz2
fix(resource): Update RegExp to allow urlParams with out leading slash
Will allow reoucese to be loaded from a relative path Example: var R = $resource(':path'); R.get({ path : 'data.json' }); Example usage: Load resources in applications not using webserver, ie local webapp in on a tablet.
-rw-r--r--src/ngResource/resource.js2
-rw-r--r--test/ngResource/resourceSpec.js12
2 files changed, 13 insertions, 1 deletions
diff --git a/src/ngResource/resource.js b/src/ngResource/resource.js
index 876035c4..914de226 100644
--- a/src/ngResource/resource.js
+++ b/src/ngResource/resource.js
@@ -270,7 +270,7 @@ angular.module('ngResource', ['ng']).
this.defaults = defaults || {};
var urlParams = this.urlParams = {};
forEach(template.split(/\W/), function(param){
- if (param && template.match(new RegExp("[^\\\\]:" + param + "\\W"))) {
+ if (param && (new RegExp("(^|[^\\\\]):" + param + "\\W").test(template))) {
urlParams[param] = true;
}
});
diff --git a/test/ngResource/resourceSpec.js b/test/ngResource/resourceSpec.js
index 9eb32d8d..bfed3082 100644
--- a/test/ngResource/resourceSpec.js
+++ b/test/ngResource/resourceSpec.js
@@ -122,6 +122,18 @@ describe("resource", function() {
R.get({a: 'doh@fo o', ':bar': '$baz@1', '!do&h': 'g=a h'});
});
+ it('should allow relative paths in resource url', function () {
+ var R = $resource(':relativePath');
+ $httpBackend.expect('GET', 'data.json').respond('{}');
+ R.get({ relativePath: 'data.json' });
+ });
+
+ it('should handle + in url params', function () {
+ var R = $resource('/api/myapp/:myresource?from=:from&to=:to&histlen=:histlen');
+ $httpBackend.expect('GET', '/api/myapp/pear+apple?from=2012-04-01&to=2012-04-29&histlen=3').respond('{}');
+ R.get({ myresource: 'pear+apple', from : '2012-04-01', to : '2012-04-29', histlen : 3 });
+ });
+
it('should encode & in url params', function() {
var R = $resource('/Path/:a');