| Age | Commit message (Collapse) | Author | 
|---|
|  | I want to be able to use the exact same logic for the `/license` route.
To do so, we move the common logic to a new `build_response()` function.
For all responses we need to return from `build_response()`, make new
structs `HtmlResponse` and `ZipResponse` that write the response in the
desired format.
The `ZipResponse` does what we're already doing in `/license/download`.
The `HtmlResponse` will respond with HTML and show a thank-you page on
success. | 
|  | The script name isn't necessarily the same as the request path. We
really want the request path. | 
|  |  | 
|  |  | 
|  |  | 
|  | Respond with a 500 on error.
Add 'aquatic-prime' to `foreign_links` errors to be able to convert it
with `into()`. | 
|  | Read https://github.com/brettwooldridge/HikariCP/wiki/About-Pool-Sizing
recently, and reducing the pool size seemed like a good idea. | 
|  |  | 
|  | Will make it a bit easier to handle errors from `Result`s. | 
|  |  | 
|  |  | 
|  | Forgot that `include_str!` existed. Certainly makes things a lot cleaner
this way. | 
|  | If the purchaser coming from POST params is found in the database,
generate a license for the purchaser, zip the license, and send a
response containing the zipped data.
zip:
Change the writer input to a mutable reference to enable us to use the
zip data when writing to the response. Otherwise we get a borrow error. | 
|  | Use POST params `name`, `email`, and `secret` to get a purchaser from
the database.
If none exists, we should probably send a 404, otherwise we'll generate
a license for that purchaser and send it in the response as a Zip
archive. | 
|  | This binary will show a thank-you page to purchasers. I had also planned
to make a third binary to send the license file as a Zip archive, but
now I think I'm going to do that here too, working out the routing
inside this program. | 
|  | This will enable us to use the logging code in other binaries. | 
|  |  | 
|  |  | 
|  | Binary to generate a license plist. | 
|  | Want a `license-generator` binary with a hyphen. Normally I'd name my
Rust files with underscores, but I didn't want to add `[[bin]]` sections
to `Cargo.toml`. | 
|  | Want to make another binary to generate license files. | 
|  | Like what I did in edf6fceedd9b4169ceb63172c60733ef84d78951 for 500
errors, extract these errors to functions also.
Doesn't give us any gains in terms of reusability like it did before, as
we're only responding with each of these errors once, but it does clean
up the code in the `main()` function a bit. | 
|  | Clean up the `main()` function by extracting all these similar lines to
a function. | 
|  | Otherwise we get a borrow error:
    error[E0373]: closure may outlive the current function, but it borrows `pool`, which is owned by the current function
       --> src/main.rs:67:18
        |
    67  |     fastcgi::run(|mut req| {
        |                  ^^^^^^^^^ may outlive borrowed value `pool`
    ...
    123 |                 let mut cx = match pool.get_conn() {
        |                                    ---- `pool` is borrowed here
    help: to force the closure to take ownership of `pool` (and any other referenced variables), use the `move` keyword
        |
    67  |     fastcgi::run(move |mut req| {
        |                  ^^^^^^^^^^^^^^ | 
|  | This way we can ask the pool for a connection on each request instead of
trying to reuse a single connection. | 
|  | This currently errors on a borrow problem with the `cx` in the closure.
Here we get the purchaser name and email from the POST params and insert
them as a record in the database.
If all goes well, we respond with a 200. Otherwise we log errors and
respond with 500. | 
|  | Move the call to `params::parse()` from `request::verified()` into
`main()`. This enables us to access values from POST params inside the
`main()` function. We'll need this to store purchaser name and email
address. | 
|  |  | 
|  | Log incomming requests to the program's log file.
Remove the 500 error when failing to read stdin to a string. I think it
should be safe to ignore that error. Now that I think about it, we
should be logging it though. | 
|  | Previously we were responding with a 200 if all else checked out. This
seems too permissive. Only the authorised webhook requester should
receive a 200. All other requesters should be denied access. Swap the
last two responses to reflect this. | 
|  | * If no `REQUEST_METHOD` is found, send a 500 error
* If the `REQUEST_METHOD` is not "POST", send a 405
* If POST params could not be read from stdin, send 500
* If an error occurred during request verification, send 500
* If the request didn't pass verification, send 403
* Otherwise send 200 | 
|  | Make it easier on users by not requiring them to pass a signature into
the method. This means they don't have to extract the `p_signature`
param and base64 decode it themselves.
Essentially, we want to move the code from `request` that removes the
`p_signature` key and base64 decodes it into the
`paddle::verify_signature()` function.
We need to make the string-like type params in `verify_signature()`
conform additionally to `PartialEq<str>` and `PartialOrd`. Doing so
allows us to find the key "p_signature".
To remove the `p_signature` param from the iterator, we partition it
into two iterators: one for the `p_signature` entry, and another for the
rest. We then extract the value of `p_signature` and base64 decode it
for verification.
Add a new error type in case no `p_signature` entry is found in the
iterator. | 
|  | In order to verify the signature, it needs to be encoded as bytes. | 
|  | Before it only used `%H:%M:%S`. We need a date. Use
> %+	2001-07-08T00:34:60.026490+09:30	ISO 8601 / RFC 3339 date & time format.
(https://docs.rs/chrono/0.4.0/chrono/format/strftime/index.html#specifiers) | 
|  | Stop writing this information to the response text and instead put it in
the program log file. Don't want to send back unnecessary information
when testing the Paddle webhook. | 
|  | Return a `Result` from the function to pass errors through. | 
|  | The new `request::verified()` takes POST params as a string as does all
the work needed to call `paddle::verify_signature()`.
This involves extracting the `p_signature` POST parameter to get the
signature, and getting the public key PEM.
Change `params::parse()` to return a
`BTreeMap<Cow<'a, str>, Cow<'a, str>>` instead of `String` keys &
values. This is because `paddle::verify_signature()` needs a `(<&str,
&str)` iterator. Actually, it still doesn't solve the problem because
the types don't match. We need to modify the input type of
`verify_signature()`, but at least this change gives us references.
Make `params` private to the crate because we no longer need to use it
in `main()`. | 
|  | We want a dictionary to be able to remove the Paddle `p_signature` entry. | 
|  | Otherwise it doesn't indicate the name of the environment variable in
the result output:
    Error: Error(EnvVar(NotPresent), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } }) | 
|  | I had forgotten to commit the transaction, so the record I was trying to
insert wouldn't get persisted in the database. | 
|  | Manually check that our purchaser creation and database persistence
works.
Make `purchaser` entities public in order to call them. | 
|  | Realised that when we want a new purchaser, we always want to generate a
secret. This way we can call `new()` without having to call
`generate_secret()` at the call site. | 
|  | Get a file path from the `LOG_FILE` environment variable and use it for
log output.
Call `database::get_database_connection()` and log the error if it
fails.
Worried about exiting early from the FastCGI program, as DreamHost says
this causes problems
(https://help.dreamhost.com/hc/en-us/articles/217298967). But I don't
see how the program can continue without a database connection.
Return a `Result` from `main()` because it's easier to use the `?`
operator for errors that happen before logging is initialised. | 
|  | Function to establish a database connection using a connection pool.
Update `Purchaser::insert()` to take a `PooledConn` instead of a simple
`Conn`. | 
|  | Split up the code to get things a bit more organised. I want a function
to create a connection to the MySQL database and I don't want to lump it
in with the rest. | 
|  | I don't see myself using this since I have the `generate_secret()`
function now. | 
|  | The `random()` function I was using will sample a value from "the full
representable range"
(https://docs.rs/rand/0.5.5/rand/#the-two-step-process-to-get-a-random-value).
We should really be using longer numbers, so set the sample range to
integers above and including 1 billion. | 
|  | This new method generates a secret, which is a SHA1 digest of the
purchaser's name, email, and a random integer.
In order to use the `hexdigest()` method in the 'sha1' crate, I needed
to add the feature `std`
(https://docs.rs/sha1/0.6.0/sha1/struct.Sha1.html#method.hexdigest).
Needed to change the `secret` field to a `String` because otherwise the
generated digest string doesn't have a long enough lifetime to assign to
it.
Update `with_secret()` to use the new `String` type.
Update `insert()` to correctly handle the `Option` in `secret`. | 
|  | Haven't tested this at all so I have no idea if it works. Just getting a
draft committed. | 
|  | Starting to set up database interactions. We need a way to insert
purchasers into the database. |