aboutsummaryrefslogtreecommitdiffstats
path: root/code-review-difftool
AgeCommit message (Collapse)Author
2023-11-24Update copyright years on recently changed filesTeddy Wing
2023-11-24code-review-difftool: Focus new changes buffer instead of old versionTeddy Wing
Previously, the focused window in each tab was the Fugitive window that contained the old version of the file. It's nicer to have the new version focused by default, because that allows you to make changes to the local source code.
2023-07-26code-review-difftool: Use newer vim-fugitive diff commandTeddy Wing
The Fugitive documentation says that `Gdiff` is deprecated. In the current version, you need to use the `Gvdiffsplit` command to get a side-by-side diff with a vertical split.
2019-11-08code-review-difftool: Turn off swap filesTeddy Wing
When the files being opened with `difftool` are already open in a Vim instance, a 'swap file already exists' confirmation warning is displayed for each file. Bypass the warning by not saving swap files (using the -n command line option).
2019-06-17code-review-difftool: Remove `extglob` `shopt` maneuversTeddy Wing
Turns out I don't need to worry about setting or unsetting `extglob` at all because the script gets executed in a subshell. Obviously. Didn't realise or test thoroughly at first.
2019-06-17code-review-difftool: Retain old `extglob` settingTeddy Wing
If `extglob` was set, we'd always unset it. Check to see if it's set before doing anything with it, and then restore it to its original value.
2019-06-17code-review-difftool: Remove commented code from 42215fe2bbefba19308bd8Teddy Wing
This was a note preceding implementation, and is no longer needed.
2019-06-17get_merge_base(): Change default base to `master...`Teddy Wing
Add the range filter to try to remove commits that we don't care about. Still not sure if this will work in all cases, as sometimes `..` seemed to give me the right collection of files and sometimes `...` did. code-review-difftool: Pass the merge base without range dots (`..` or `...`) to Vim Fugitive, as it doesn't accept revisions with ranges. Not sure what to do if I get a range with two revision names yet, though. Turns on Bash's `extglob` in order to use `?(...)` to include both patterns in the expansion.
2019-06-10Add license (GNU GPLv3+)Teddy Wing
2019-06-10code-review-difftool: Remove completed TODOsTeddy Wing
2019-06-10code-review-difftool: Use `code-review-changed-files`Teddy Wing
Use the existing `code-review` tool instead of the full Git command.
2019-06-10Use `get_merge_base` across scriptsTeddy Wing
Replace `$ARGS` system from before with the merge base value taken from the database. This makes the merge base consistent across `code-review` tools/subcommands.
2019-06-09code-review-difftool: Change `master..` to `master`Teddy Wing
Turns out some files were excluded using the `..` range.
2019-06-04code-review-difftool: Use 'vim-fugitive' instead of 'vdwrap'Teddy Wing
Fugitive seems to have fewer surprises and basically just work in Vim.
2019-06-03Move `code-review` to `code-review-difftool`Teddy Wing
Going to set up a Git-style subcommand system where subcommands are separate executables.