From 288da883a3a4a91fec67029b7695ec03099cfc46 Mon Sep 17 00:00:00 2001
From: Teddy Wing
Date: Sat, 3 Jun 2017 14:16:29 +0200
Subject: Initial stab at submitting time entries for real

main.go:
* Login as the configured user (haven't yet handled making `PasswordCmd`
  an actual shell command)
* Create a test time entry
* Submit that time entry using `SubmitTimeEntry()`

http.go:
* Create a `baseURL` global that stores the base TimeTask URL to make
  requests to
* Return an `http.Client` from `Login()` that can then be passed to
  `SubmitTimeEntry()` to reuse the login session. Needed to return a
  pointer to allow us to return `nil` from the first error handler in
  the function. Don't like that at all, but we're just trying to get it
  to work at this point.
* Actually make an HTTP POST request in `SubmitTimeEntry()` using the
  given HTTP Client and existing time entry submission params
* Take an `http.Client` argument in `SubmitTimeEntry()` to allow us to
  use a logged-in session to POST. Otherwise we'd be locked out.
* Change `v` variable to `values` in `SubmitTimeEntry()` for better
  readability
---
 timetask/http.go | 35 +++++++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 10 deletions(-)

(limited to 'timetask')

diff --git a/timetask/http.go b/timetask/http.go
index 4f52565..cb91257 100644
--- a/timetask/http.go
+++ b/timetask/http.go
@@ -12,15 +12,21 @@ import (
 	"golang.org/x/net/publicsuffix"
 )
 
-func Login(username, password string) (resp *http.Response, err error) {
+var baseURL string = "https://af83.timetask.com/index.php"
+
+func Login(username, password string) (
+	resp *http.Response,
+	client *http.Client,
+	err error,
+) {
 	cookies, err := cookiejar.New(&cookiejar.Options{PublicSuffixList: publicsuffix.List})
 	if err != nil {
-		return nil, err
+		return nil, nil, err
 	}
 
-	client := http.Client{Jar: cookies}
+	client = &http.Client{Jar: cookies}
 	resp, err = client.PostForm(
-		"https://af83.timetask.com/index.php",
+		baseURL,
 		url.Values{
 			"module":     {"people"},
 			"action":     {"loginsubmit"},
@@ -30,21 +36,30 @@ func Login(username, password string) (resp *http.Response, err error) {
 		},
 	)
 	if err != nil {
-		return resp, err
+		return resp, client, err
 	}
 
-	return resp, err
+	return resp, client, err
 }
 
 func SubmitTimeEntry(
+	client http.Client,
 	time_entry TimeEntry,
 ) (resp *http.Response, err error) {
-	v := buildSubmissionParams(time_entry)
+	values := buildSubmissionParams(time_entry)
 
-	v.Set("module", "time")
-	v.Set("action", "submitmultipletime")
+	values.Set("module", "time")
+	values.Set("action", "submitmultipletime")
+
+	resp, err = client.PostForm(
+		baseURL,
+		values,
+	)
+	if err != nil {
+		return resp, err
+	}
 
-	return nil, nil
+	return resp, nil
 }
 
 
-- 
cgit v1.2.3