From 6d5c4ff7710f37ff75ffaf6465d529a2fce64d38 Mon Sep 17 00:00:00 2001
From: Teddy Wing
Date: Sat, 25 Nov 2023 14:56:15 +0100
Subject: swextreload: Explain why we don't cancel certain contexts

---
 internal/swextreload.go | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

(limited to 'internal')

diff --git a/internal/swextreload.go b/internal/swextreload.go
index ffa083d..92dd1b8 100644
--- a/internal/swextreload.go
+++ b/internal/swextreload.go
@@ -153,8 +153,9 @@ func reloadTab(
 	letarget *target.Info,
 	isExtensionManifestV2 bool,
 ) error {
+	// Don't cancel the context. Otherwise, the background page DevTools
+	// window closes.
 	ctx, cancel := chromedp.NewContext(ctx)
-	// defer cancel()
 
 	logDebugf("Reload tab (Manifest V2: %t)", isExtensionManifestV2)
 
@@ -194,8 +195,9 @@ func reloadTab(
 	} else {
 		logDebugf("Connecting to target %s", letarget.TargetID)
 
-		ctx, cancel = chromedp.NewContext(ctx, chromedp.WithTargetID(letarget.TargetID))
-		// defer cancel()
+		// Don't cancel the context. Otherwise, the background page DevTools
+		// window closes.
+		ctx, _ = chromedp.NewContext(ctx, chromedp.WithTargetID(letarget.TargetID))
 	}
 
 	var tabsResp []byte
-- 
cgit v1.2.3