From 278db85ab836948bc11fe2d26da126fc7695c083 Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sun, 30 May 2021 00:15:36 +0200 Subject: database::repo_get: Don't need my own error for empty row Sqlx already returns an appropriate error if no row was found. --- Cargo.toml | 2 +- src/database.rs | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 588ee18..182ccdf 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -11,4 +11,4 @@ tokio = { version = "1.6.1", features = ["macros", "rt"] } [dependencies.sqlx] version = "0.5.5" -features = ["chrono", "macros", "runtime-tokio-rustls", "sqlite"] +features = ["chrono", "runtime-tokio-rustls", "sqlite"] diff --git a/src/database.rs b/src/database.rs index a49675f..e4ca5e9 100644 --- a/src/database.rs +++ b/src/database.rs @@ -58,6 +58,7 @@ impl Db { ) -> Result> { let mut tx = self.connection.begin().await?; + // NOTE: Returns `RowNotFound` if not found. let row = sqlx::query("SELECT id, name FROM repositories where id = ?") .bind(id) .fetch_one(&mut tx) @@ -65,10 +66,6 @@ impl Db { tx.commit().await?; - if row.is_empty() { - return Err("not found".into()); - } - Ok( Repo { id: Some(row.get(0)), -- cgit v1.2.3