kipper/src, branch master Update GitHub commit statuses from Jenkins build results main(): Change server from `127.0.0.1` to `0.0.0.0` 2017-11-22T18:50:26+00:00 Teddy Wing 2017-11-22T18:50:26+00:00 1714aa14ca989a5f25c02352da219100d1091106 Make the default server address `0.0.0.0` to make the server accessible from inside a Docker container. 
Make the default server address `0.0.0.0` to make the server accessible
from inside a Docker container.
find_and_track_build_and_update_status(): Send Jenkins console URL 2017-11-17T00:33:26+00:00 Teddy Wing 2017-11-17T00:33:26+00:00 ad9537963fe3eb6589ecdec0c6f9f001a483f5e2 When adding a GitHub commit status, instead of using the job "home" URL, use the URL of its "Console" page. This page shows the build log and is much more useful than the other one. If there's a build failure in particular, you'd be going to this page anyway to see what the problem was, so using this `target_url` saves a click. 
When adding a GitHub commit status, instead of using the job "home" URL,
use the URL of its "Console" page. This page shows the build log and is
much more useful than the other one. If there's a build failure in
particular, you'd be going to this page anyway to see what the problem
was, so using this `target_url` saves a click.
jenkins.rs: Add `jenkins_console_url_path()` 2017-11-17T00:26:13+00:00 Teddy Wing 2017-11-17T00:26:13+00:00 6a2f2232cb3bd26e512c1383a581544bc0aef731 A new function that will return the URL to the Jenkins "Console" page given the URL of a Jenkins job. We'll be using this to pass with the GitHub status request as the `target_url`. 
A new function that will return the URL to the Jenkins "Console" page
given the URL of a Jenkins job.

We'll be using this to pass with the GitHub status request as the
`target_url`.
main(): Don't update commit status unless commits were pushed 2017-11-17T00:08:55+00:00 Teddy Wing 2017-11-17T00:08:55+00:00 399e04a697e42c9a684f14349f6d94208e719832 There are a bunch of events that can trigger the `pull_request` webhook. These are: "assigned", "unassigned", "review_requested", "review_request_removed", "labeled", "unlabeled", "opened", "edited", "closed", or "reopened". And "synchronize". We only care about "opened" and "synchronize" because those are the only two where new commits can come through. Since we don't set commit statuses unless that commit is part of a pull request, we need a way to update the status the first time a pull request is opened, thus the "opened" action. When new commits are added we also want to update statuses, so "synchronize". But for the others, we don't want to be duplicating work and adding duplicate unnecessary statuses to PR commits. 
There are a bunch of events that can trigger the `pull_request` webhook.
These are:

    "assigned", "unassigned", "review_requested",
    "review_request_removed", "labeled", "unlabeled", "opened",
    "edited", "closed", or "reopened". And "synchronize".

We only care about "opened" and "synchronize" because those are the only
two where new commits can come through. Since we don't set commit
statuses unless that commit is part of a pull request, we need a way to
update the status the first time a pull request is opened, thus the
"opened" action. When new commits are added we also want to update
statuses, so "synchronize". But for the others, we don't want to be
duplicating work and adding duplicate unnecessary statuses to PR
commits.
CommitRef::new(): Take a `JsonValue` instead of an `&str` 2017-11-16T23:54:27+00:00 Teddy Wing 2017-11-16T23:54:27+00:00 205fc3b71bd44067685c8517e7d126e3574827e1 We expect to have pre-parsed the JSON as this function will get called after `pull_request_opened_or_synchronized()`. To avoid doing the same JSON parsing work twice, take a `JsonValue` argument in both functions. 
We expect to have pre-parsed the JSON as this function will get called
after `pull_request_opened_or_synchronized()`. To avoid doing the same
JSON parsing work twice, take a `JsonValue` argument in both functions.
pull_request.rs: Add `pull_request_opened_or_synchronized()` 2017-11-16T23:47:26+00:00 Teddy Wing 2017-11-16T23:47:26+00:00 cef74cbc8ccfac2b371db2cc9e99dda3c1fce166 A new function that, given the parsed JSON from a pull request webhook, tells us whether the pull request was "opened" or "synchronize"d with a boolean. This will enable us to only update commit statuses when actions on the pull request result in new commits being available. Otherwise, we don't want to set a commit status that we've already set before. 
A new function that, given the parsed JSON from a pull request webhook,
tells us whether the pull request was "opened" or "synchronize"d with a
boolean.

This will enable us to only update commit statuses when actions on the
pull request result in new commits being available. Otherwise, we don't
want to set a commit status that we've already set before.
main(): Move `body` var definition to where it's used 2017-11-16T23:20:47+00:00 Teddy Wing 2017-11-16T23:20:47+00:00 7a4b816b6dc8c826db49bc5997709b8e7d1f6933 Don't bother creating the variable if we don't receive any data. Instead, initialise the variable right where we need it. 
Don't bother creating the variable if we don't receive any data.
Instead, initialise the variable right where we need it.
pull_request.rs: Remove old comments from test 2017-11-16T23:14:22+00:00 Teddy Wing 2017-11-16T23:14:22+00:00 47ec45de9808045dc6b0c6a209727764ac627e82 These are no longer relevant. 
These are no longer relevant.
Remove commented log calls from Jenkins requests 2017-11-16T23:13:35+00:00 Teddy Wing 2017-11-16T23:13:35+00:00 34c8e2a893095e3b15ddf0a5d4f7b521aeebde22 We're not using these any more, so they can be removed. 
We're not using these any more, so they can be removed.
Merge remote-tracking branch 'origin/fix-final-status-update-call' 2017-11-16T23:10:35+00:00 Teddy Wing 2017-11-16T23:10:35+00:00 9dd7d28ec05830220133ae32db5d31835f523c81 Conflicts: src/jenkins.rs 
Conflicts:
	src/jenkins.rs