From 8efe2cc2f9495b60b5a27f818af7d666651aee4d Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sun, 21 May 2023 21:39:48 +0200 Subject: Report function signature declaration using variable name other than err I had previously hard-coded the variable name "err" as the recommended name declaration in the function signature for simplicity. Now, use the name assigned in the `defer` instead, which is more correct. --- testdata/signature.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'testdata/signature.go') diff --git a/testdata/signature.go b/testdata/signature.go index 73203ee..b668558 100644 --- a/testdata/signature.go +++ b/testdata/signature.go @@ -45,6 +45,21 @@ func returnedErrorMustMatchDeferErrorName() (err error) { return err2 // want "does not return 'err'" } +func deferUsesUnconventionalErrName() error { // want "return signature should be '\\(anErr error\\)'" + var anErr error + + anErr = nil + if anErr != nil { + return anErr + } + + defer func() { + anErr = errors.New("defer error") + }() + + return anErr +} + func good() (err error) { err = nil if err != nil { -- cgit v1.2.3