From 44330f11a5f521f7cb8ed9de6956923c457ae50f Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sun, 21 May 2023 00:11:53 +0200 Subject: Add test to ensure error vars declared in defer closure are not reported --- defererr.go | 2 ++ 1 file changed, 2 insertions(+) (limited to 'defererr.go') diff --git a/defererr.go b/defererr.go index 8d1cb51..a4e6c8d 100644 --- a/defererr.go +++ b/defererr.go @@ -144,6 +144,8 @@ func run(pass *analysis.Pass) (interface{}, error) { } } + // Maybe don't report the error if it was declared in the closure using a GenDecl? -> We already don't. Should test for these things. + if !isErrorNameInReturnSignature { pass.Reportf( errorReturnField.Pos(), -- cgit v1.2.3