From 58a0e1906d669a5a7c4e7f0ca4308a8af859880a Mon Sep 17 00:00:00 2001
From: Teddy Wing
Date: Wed, 17 May 2023 19:20:08 +0200
Subject: Add notes about false positives that should be corrected

---
 gocapturedrefrace.go | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gocapturedrefrace.go b/gocapturedrefrace.go
index 10ab437..1521ed0 100644
--- a/gocapturedrefrace.go
+++ b/gocapturedrefrace.go
@@ -51,6 +51,8 @@ func run(pass *analysis.Pass) (interface{}, error) {
 
 				// Inspect closure argument list.
 				for _, arg := range funcLit.Type.Params.List {
+					// TODO: Ignore closures passed as arguments.
+
 					// Report reference arguments.
 					_, ok := arg.Type.(*ast.StarExpr)
 					if !ok {
@@ -106,6 +108,8 @@ func checkClosure(pass *analysis.Pass, funcLit *ast.FuncLit) {
 				return true
 			}
 
+			// TODO: Ignore shadowing variables.
+
 			// Identifier was defined in a different scope.
 			if funcScope != scope {
 				pass.Reportf(
-- 
cgit v1.2.3