From 38a871f28bad90e238021d8cc46b9fa926f9df75 Mon Sep 17 00:00:00 2001 From: Teddy Wing Date: Sun, 2 Aug 2020 04:31:11 +0200 Subject: git-sugpatch: Error if no remote and suggestion ID argument We want to allow not having a remote when URL arguments are given, but require it when a suggestion ID argument is given (otherwise we wouldn't have an owner-repo pair to make the GitHub request). Had some trouble with the `OwnerRepo.o_r` value. It was being moved into the closure, so tried a loop. There was a similar problem with the loop. However, by returning, I was able to get a reference to the `Result` instead of having it be moved. --- src/error.rs | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/error.rs') diff --git a/src/error.rs b/src/error.rs index bcca3e1..3df5de7 100644 --- a/src/error.rs +++ b/src/error.rs @@ -1,11 +1,16 @@ use regex; use thiserror::Error; +use crate::owner_repo; + #[derive(Debug, Error)] pub enum Error { #[error("Unable to parse regex")] Regex(#[from] regex::Error), + + #[error(transparent)] + NoRemote(#[from] owner_repo::Error), } -- cgit v1.2.3