git-suggestion/src/bin, branch v0.2.1

git-suggestion-cli: Rename crate to `git-suggestion`

2020-08-30T02:51:51+00:00

Now that I'm using the name "git-suggestion" in a few places, and from a
user perspective, it's more Git-oriented than GitHub-oriented, I think
the crate should be renamed to reflect that.

diff_options: Clean up code

2020-08-29T23:20:33+00:00

Remove old process code and comments.

git-sugdiff: Fix output by waiting for child process

2020-08-29T20:58:33+00:00

I thought I'd resolved this problem by adding the `--no-pager` flag in
76079daf1e2175d02c9c584e47a21650fce30bb6, but it turns out that didn't
fix it.

When running the command, I'd get the following output, with the shell
prompt preceding the start of the diff, and the command hanging without
exiting to a new prompt line until a new interaction:

    $ ./target/debug/git-sugdiff 459692838
    $ diff --git a/src/server.rs b/44ff3b520321467a9220965d13f997690ff3fda7
    index d9eee95..44ff3b5 100644
    --- a/src/server.rs
    +++ b/44ff3b520321467a9220965d13f997690ff3fda7
    @@ -73,7 +73,7 @@ impl Server {
                            internal_server_error(&mut raw_request.stdout())
                        },
                        Error::ConduitResponse { .. } => {
                            error!("Error [-getting-]{+from+} response: {}", e);

                            internal_server_error(&mut raw_request.stdout())
                        },

Turns out I need to wait for the command to exit in order to properly
execute the external command.

git-sugdiff: Use `diff_options.parse()` to extract diff options

2020-08-29T17:33:19+00:00

Config::get():
Change `args` type so we can pass both a `Vec` and
`Vec<&String>`.

diff_options.parse():
* Split diff arguments and program arguments by returning a tuple.
* Exit the args loop once we've parsed an argument.
* Update test
* Add a non-working test for suggestion arguments. An `OPT_OPTIONS`
  argument could be followed by an argument that's not the value of the
  `OPT_OPTIONS` option. Currently, that arg will always be parsed as the
  value. We need to handle this case.

Add `diff_options` to parse Git diff options

2020-08-26T19:41:36+00:00

In order to accept Git diff options on the command line, we need a way
to extract these from args.

Add a function to parse diff options. These were sourced from:

https://github.com/git/git/blob/675a4aaf3b226c0089108221b96559e0baae5de9/Documentation/diff-options.txt

The function loops through the input arguments and extracts all diff
options and their values.

Still needs some work to integrate it into `git-sugdiff`, but it
currently works as advertised.

git-sugdiff: Replace `unwrap`s with proper error handling

2020-08-23T19:18:55+00:00

Rename `git-sugpatch` to `git-sugdiff`

2020-08-23T18:55:08+00:00

The word "patch" reminds me more of the `patch` Unix command, which is
what `git-sugapply` does.

Since this command outputs diffs, it makes more sense to call it
`sugdiff`. That also brings these closer to the native Git commands,
`git-diff` and `git-apply`.

I had chosen "patch" originally because the command generated a unified
diff that could be used as a patch file to apply to the repo.

git-sugdiff: Remove TODO

2020-08-23T18:41:11+00:00

This works now, thanks to 3c6f337e26964077d1ce629fa17d16e4484b877f.

Suggestion: Rename `diff_command()` to `blob()`

2020-08-23T17:45:28+00:00

This function is no longer calling the `git diff` command, so this name
doesn't make sense.

git-sugdiff: Add `--no-pager` to `git diff` command

2020-08-23T16:38:34+00:00

The diff command wasn't exiting after outputting the diff. Add the
`--no-pager` argument to ensure that the pager doesn't activate. This
also seems to cause the command to exit once all the output is printed.

We don't want the pager because we need to call `git diff` for each
suggestion. If an early diff took up more than a page and activated the
pager, that would block the next diffs from appearing. We want them all
to appear at once.