git-suggestion, branch v0.2.0 Diffs and patches for GitHub pull request suggestions Increase version v0.1.0 -> v0.2.0 2020-08-30T18:18:25+00:00 Teddy Wing 2020-08-30T03:47:07+00:00 63610d9a6378c0febb0ef7fceb72c477a2ca6899 






git-suggestion-cli: Rename crate to `git-suggestion`
2020-08-30T02:51:51+00:00

Teddy Wing

2020-08-30T02:51:51+00:00

4477ae635ec67d2b79ac670bbd73b88d4979e786

Now that I'm using the name "git-suggestion" in a few places, and from a
user perspective, it's more Git-oriented than GitHub-oriented, I think
the crate should be renamed to reflect that.





Now that I'm using the name "git-suggestion" in a few places, and from a
user perspective, it's more Git-oriented than GitHub-oriented, I think
the crate should be renamed to reflect that.







doc/git-sugdiff.1: Add a note about Git diff option support
2020-08-30T02:27:39+00:00

Teddy Wing

2020-08-30T02:27:39+00:00

436c09d6484b657056db07f68b11da116bbd0307

Not sure if I should be emphasising this more.





Not sure if I should be emphasising this more.







diff_options: Add doc comments
2020-08-30T00:59:42+00:00

Teddy Wing

2020-08-30T00:59:42+00:00

118d466716ca688e3d1f5857cf8ea35b23c8e704












diff_options: Sort and uniq `FLAGS`
2020-08-30T00:56:23+00:00

Teddy Wing

2020-08-30T00:56:23+00:00

61e582cf930bfa0bbc20c5c7c3c4b3a6098ce53e

Make the list easier to scan by ordering it alphabetically. Also, I
noticed there were two `-p` flags listed, so ran the flags through
`uniq`.





Make the list easier to scan by ordering it alphabetically. Also, I
noticed there were two `-p` flags listed, so ran the flags through
`uniq`.







diff_options::parse(): Rename `found_args` to `diff_args`
2020-08-30T00:56:12+00:00

Teddy Wing

2020-08-30T00:50:28+00:00

da974e4d4ce45ee7798b53b52b3a152dfb56eaae

Now that I added `program_args`, reading this back over I realised
`found_args` didn't convey enough information about what it contains.





Now that I added `program_args`, reading this back over I realised
`found_args` didn't convey enough information about what it contains.







diff_options: Merge `FLAGS` and `OPTIONS`
2020-08-30T00:41:15+00:00

Teddy Wing

2020-08-30T00:41:15+00:00

2b1e644ead40145f0b1b84f286b48948fb314311

Didn't look closely enough in d9b8838a5d99e643a751d042047644cfa4a9a032,
but we now have the exact same handling for key-value options and flags.





Didn't look closely enough in d9b8838a5d99e643a751d042047644cfa4a9a032,
but we now have the exact same handling for key-value options and flags.







diff_options: Merge `ARG_OPTIONS` and `OPT_OPTIONS`
2020-08-29T23:44:25+00:00

Teddy Wing

2020-08-29T23:44:25+00:00

d9b8838a5d99e643a751d042047644cfa4a9a032

Now that I've confirmed that Git's key value options require an '=' to
specify the value, we can drop the distinction between options that
require and argument and those that optionally take an argument.

Also remove the code that interprets an argument that doesn't start with
'-' as the value of the preceding option.





Now that I've confirmed that Git's key value options require an '=' to
specify the value, we can drop the distinction between options that
require and argument and those that optionally take an argument.

Also remove the code that interprets an argument that doesn't start with
'-' as the value of the preceding option.







diff_options: Clean up code
2020-08-29T23:20:33+00:00

Teddy Wing

2020-08-29T23:20:33+00:00

905594dc8393f97c1a960d639af46175b3e6b76f

Remove old process code and comments.





Remove old process code and comments.







git-sugdiff: Fix output by waiting for child process
2020-08-29T20:58:33+00:00

Teddy Wing

2020-08-29T20:58:33+00:00

b9729227347e0532891321548b31579b80376bdd

I thought I'd resolved this problem by adding the `--no-pager` flag in
76079daf1e2175d02c9c584e47a21650fce30bb6, but it turns out that didn't
fix it.

When running the command, I'd get the following output, with the shell
prompt preceding the start of the diff, and the command hanging without
exiting to a new prompt line until a new interaction:

    $ ./target/debug/git-sugdiff 459692838
    $ diff --git a/src/server.rs b/44ff3b520321467a9220965d13f997690ff3fda7
    index d9eee95..44ff3b5 100644
    --- a/src/server.rs
    +++ b/44ff3b520321467a9220965d13f997690ff3fda7
    @@ -73,7 +73,7 @@ impl Server {
                            internal_server_error(&mut raw_request.stdout())
                        },
                        Error::ConduitResponse { .. } => {
                            error!("Error [-getting-]{+from+} response: {}", e);

                            internal_server_error(&mut raw_request.stdout())
                        },

Turns out I need to wait for the command to exit in order to properly
execute the external command.





I thought I'd resolved this problem by adding the `--no-pager` flag in
76079daf1e2175d02c9c584e47a21650fce30bb6, but it turns out that didn't
fix it.

When running the command, I'd get the following output, with the shell
prompt preceding the start of the diff, and the command hanging without
exiting to a new prompt line until a new interaction:

    $ ./target/debug/git-sugdiff 459692838
    $ diff --git a/src/server.rs b/44ff3b520321467a9220965d13f997690ff3fda7
    index d9eee95..44ff3b5 100644
    --- a/src/server.rs
    +++ b/44ff3b520321467a9220965d13f997690ff3fda7
    @@ -73,7 +73,7 @@ impl Server {
                            internal_server_error(&mut raw_request.stdout())
                        },
                        Error::ConduitResponse { .. } => {
                            error!("Error [-getting-]{+from+} response: {}", e);

                            internal_server_error(&mut raw_request.stdout())
                        },

Turns out I need to wait for the command to exit in order to properly
execute the external command.