From ae1a54157291c0bcc69a6e8652bc15e69b72b4e4 Mon Sep 17 00:00:00 2001
From: Stephen Blott
Date: Sat, 16 Apr 2016 16:36:35 +0100
Subject: Do not focus a hidden help dialog.

When the help dialog UI component has been created but subsequently
hidden, `gf` was nevertheless selecting it.
---
 pages/help_dialog.coffee | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

(limited to 'pages')

diff --git a/pages/help_dialog.coffee b/pages/help_dialog.coffee
index 0300ec00..7fee8bf9 100644
--- a/pages/help_dialog.coffee
+++ b/pages/help_dialog.coffee
@@ -6,7 +6,8 @@
 #   top-level frame), and then we don't need to be concerned about nested help dialog frames.
 HelpDialog =
   dialogElement: null
-  isShowing: -> true
+  showing: false
+  isShowing: -> @showing
 
   # This setting is pulled out of local storage. It's false by default.
   getShowAdvancedCommands: -> Settings.get("helpDialog_showAdvancedCommands")
@@ -69,8 +70,10 @@ HelpDialog =
 UIComponentServer.registerHandler (event) ->
   switch event.data.name ? event.data
     when "hide" then HelpDialog.hide()
+    when "hidden" then HelpDialog.showing = false
     when "activate"
       HelpDialog.init()
+      HelpDialog.showing = true
       HelpDialog.show event.data
 
 root = exports ? window
-- 
cgit v1.2.3