From 740df9a23fa9a1e5b812584ce0702b813b226623 Mon Sep 17 00:00:00 2001
From: Stephen Blott
Date: Tue, 19 Apr 2016 13:32:39 +0100
Subject: Help dialog; do not offer hints outside of the help dialog.

---
 pages/help_dialog.coffee | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'pages/help_dialog.coffee')

diff --git a/pages/help_dialog.coffee b/pages/help_dialog.coffee
index 401c3222..ebcf8486 100644
--- a/pages/help_dialog.coffee
+++ b/pages/help_dialog.coffee
@@ -38,7 +38,7 @@ HelpDialog =
       do (element) ->
         element.setAttribute "role", "link"
         element.addEventListener "click", ->
-          commandName = element.textContent.replace("(","").replace ")", ""
+          commandName = element.textContent
           chrome.runtime.sendMessage handler: "copyToClipboard", data: commandName
           HUD.showForDuration("Yanked #{commandName}.", 2000)
 
@@ -82,3 +82,4 @@ UIComponentServer.registerHandler (event) ->
 
 root = exports ? window
 root.HelpDialog = HelpDialog
+root.isVimiumHelpDialog = true
-- 
cgit v1.2.3


From 4c707140985ae03e3c523f2e6e4b6cb4c8465236 Mon Sep 17 00:00:00 2001
From: Stephen Blott
Date: Fri, 22 Apr 2016 16:03:26 +0100
Subject: Better help-dialog formatting.

Use margins to centre the help dialog.  This works better on narrow
windows, and seems to produce a balanced dialog in a variety of cases.
---
 pages/help_dialog.coffee | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'pages/help_dialog.coffee')

diff --git a/pages/help_dialog.coffee b/pages/help_dialog.coffee
index ebcf8486..6eb13660 100644
--- a/pages/help_dialog.coffee
+++ b/pages/help_dialog.coffee
@@ -15,7 +15,7 @@ HelpDialog =
         clickEvent.preventDefault()
         @hide()
       false)
-    @dialogElement.getElementsByClassName("optionsPage")[0].addEventListener("click", (clickEvent) ->
+    document.getElementById("helpDialogOptionsPage").addEventListener("click", (clickEvent) ->
         clickEvent.preventDefault()
         chrome.runtime.sendMessage({handler: "openOptionsPageInNewTab"})
       false)
-- 
cgit v1.2.3


From 98ea279485fc456bbe4349559f9c08a24e2c4214 Mon Sep 17 00:00:00 2001
From: Stephen Blott
Date: Sat, 23 Apr 2016 06:53:55 +0100
Subject: Show tip re. clicking command names.

It's pretty undiscoverable that you can click command names to yank
them.  So, this adds a tip to the bottom of the help dialog.

Also, change the cursor to a pointer when hovering over command names.
---
 pages/help_dialog.coffee | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'pages/help_dialog.coffee')

diff --git a/pages/help_dialog.coffee b/pages/help_dialog.coffee
index 6eb13660..28aafb4a 100644
--- a/pages/help_dialog.coffee
+++ b/pages/help_dialog.coffee
@@ -19,7 +19,7 @@ HelpDialog =
         clickEvent.preventDefault()
         chrome.runtime.sendMessage({handler: "openOptionsPageInNewTab"})
       false)
-    @dialogElement.getElementsByClassName("toggleAdvancedCommands")[0].addEventListener("click",
+    document.getElementById("toggleAdvancedCommands").addEventListener("click",
       HelpDialog.toggleAdvancedCommands, false)
 
     document.documentElement.addEventListener "click", (event) =>
@@ -58,7 +58,7 @@ HelpDialog =
     Settings.set("helpDialog_showAdvancedCommands", !showAdvanced)
 
   showAdvancedCommands: (visible) ->
-    HelpDialog.dialogElement.getElementsByClassName("toggleAdvancedCommands")[0].innerHTML =
+    document.getElementById("toggleAdvancedCommands").innerHTML =
       if visible then "Hide advanced commands" else "Show advanced commands"
 
     # Add/remove the showAdvanced class to show/hide advanced commands.
-- 
cgit v1.2.3