From aaad228ca659f0d3d29b732df26b9770a3dea89c Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Sat, 20 Feb 2016 07:26:48 +0000 Subject: Correctly set `settingsVersion`. This fixes an error in #1950. There, we need to detect new installs, and did so by checking `settingsVersion`. However, `settingsVersion` is *always* truthy. So the "new install" code never triggers. Here, the default value for `settingsVersion` is falsy. Note, we *always* set `settingsVersion` when the extension is loaded. So `settingsVersion` is always set. --- lib/settings.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/settings.coffee b/lib/settings.coffee index da45eb61..914ef229 100644 --- a/lib/settings.coffee +++ b/lib/settings.coffee @@ -172,7 +172,7 @@ Settings = regexFindMode: false waitForEnterForFilteredHints: false # Note: this defaults to true for new users; see below. - settingsVersion: Utils.getCurrentVersion() + settingsVersion: "" helpDialog_showAdvancedCommands: false optionsPage_showAdvancedOptions: false passNextKeyKeys: [] -- cgit v1.2.3