From 36ba08a4e14f7de05b3357b35666e7351083998d Mon Sep 17 00:00:00 2001 From: Björn Date: Fri, 27 Apr 2012 21:23:45 +0200 Subject: flashElement: use an overlay, so zero-sized links are flashed as well (no css manupulation of the target element) Conflicts: lib/domUtils.js --- lib/domUtils.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/domUtils.js b/lib/domUtils.js index ee17d45f..06bffa42 100644 --- a/lib/domUtils.js +++ b/lib/domUtils.js @@ -106,10 +106,15 @@ var domUtils = { }, // momentarily flash a border around an element to give user some visual feedback - flashElement: function(element) { - var oldBorderValue = element.style.border; - element.style.border = '1px solid #66f'; - setTimeout(function(){element.style.border = oldBorderValue;}, 400); + flashElement: function(element, rect) { + var flashEl = document.createElement("div"); + flashEl.id = "vimiumFlash"; + flashEl.style.left = rect.left + window.scrollX + "px"; + flashEl.style.top = rect.top + window.scrollY + "px"; + flashEl.style.width = rect.width + "px"; + flashEl.style.height = rect.height + "px"; + document.body.appendChild(flashEl); + setTimeout(function() { flashEl.parentNode.removeChild(flashEl); delete flashEl; }, 400); }, }; -- cgit v1.2.3