From e616a4ccc1b405835e48523ed9bd626a189b4130 Mon Sep 17 00:00:00 2001 From: Joey Baker Date: Thu, 22 Aug 2013 05:18:54 -0700 Subject: Some events don't have `keyIdentifier` This was throwing an error for me on some events.--- content_scripts/vimium_frontend.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'content_scripts') diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index 8ce28382..4dcddbc5 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -359,8 +359,8 @@ onKeydown = (event) -> # handle special keys, and normal input keys with modifiers being pressed. don't handle shiftKey alone (to # avoid / being interpreted as ? - if (((event.metaKey || event.ctrlKey || event.altKey) && event.keyCode > 31) || - event.keyIdentifier.slice(0, 2) != "U+") + if (((event.metaKey || event.ctrlKey || event.altKey) && event.keyCode > 31) || ( + event.keyIdentifier && event.keyIdentifier.slice(0, 2) != "U+")) keyChar = KeyboardUtils.getKeyChar(event) # Again, ignore just modifiers. Maybe this should replace the keyCode>31 condition. if (keyChar != "") -- cgit v1.2.3