From 92d2b4058a378c276d52ecc53409603679c3865c Mon Sep 17 00:00:00 2001 From: mrmr1993 Date: Thu, 21 Sep 2017 21:47:46 +0100 Subject: Move simulating click default action to DomUtils, add shift handling --- content_scripts/link_hints.coffee | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) (limited to 'content_scripts') diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index 0fbb66bf..eeadfc0c 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -384,17 +384,7 @@ class LinkHintsMode window.focus() DomUtils.simulateSelect clickEl else - clickActivator = (modifiers) -> (link) -> - defaultActionsTriggered = DomUtils.simulateClick link, modifiers - simulateClickDefaultAction = Utils.isFirefox() - if simulateClickDefaultAction and - defaultActionsTriggered[3] and link.tagName?.toLowerCase() == "a" and - modifiers? and modifiers.metaKey == isMac and modifiers.ctrlKey == not isMac - # We've clicked a link that *should* open in a new tab. If simulateClickDefaultAction is true, - # we assume the popup-blocker is active, and simulate opening the new tab ourselves. - chrome.runtime.sendMessage {handler: "openUrlInNewTab", url: link.href, active: - modifiers.shiftKey == true} - + clickActivator = (modifiers) -> (link) -> DomUtils.simulateClick link, modifiers linkActivator = @mode.linkActivator ? clickActivator @mode.clickModifiers # TODO: Are there any other input elements which should not receive focus? if clickEl.nodeName.toLowerCase() in ["input", "select"] and clickEl.type not in ["button", "submit"] -- cgit v1.2.3