From 8f63e5fed000fcae50277e7886b828d9bc87da34 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Sat, 25 Nov 2017 11:37:44 +0000 Subject: Tweak #2783. Tiny tweaks... 1. The test is clearer like this. 2. Use a more CoffeeScript-ish approach to sub-string. --- content_scripts/link_hints.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'content_scripts') diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index 6be163ef..0592c96d 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -818,11 +818,11 @@ LocalHints = nodeName = element.nodeName.toLowerCase() if nodeName == "input" - if element.labels?.length > 0 + if element.labels? and element.labels.length > 0 linkText = element.labels[0].textContent.trim() # Remove trailing ":" commonly found in labels. if linkText[linkText.length-1] == ":" - linkText = linkText.substr 0, linkText.length-1 + linkText = linkText[...linkText.length-1] showLinkText = true else if element.getAttribute("type")?.toLowerCase() == "file" linkText = "Choose File" -- cgit v1.2.3