From 8e4e95c87d2ea06fcc0d9d354a180dfa1f31cdd2 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Thu, 6 Nov 2014 15:23:25 +0000 Subject: Prune unnecessary stuff in ensureScrollChange. --- content_scripts/scroller.coffee | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'content_scripts') diff --git a/content_scripts/scroller.coffee b/content_scripts/scroller.coffee index 8eb50d77..b3a14c78 100644 --- a/content_scripts/scroller.coffee +++ b/content_scripts/scroller.coffee @@ -38,11 +38,10 @@ ensureScrollChange = (direction, changeFn) -> element = activatedElement loop oldScrollValue = element[axisName] - overflow = window.getComputedStyle(element, null).getPropertyValue("overflow-#{direction}") - # Elements with `overflow: hidden` don't natively have scrolling, so we shouldn't scroll them. + # Elements with `overflow: hidden` should not be scrolled. + overflow = window.getComputedStyle(element).getPropertyValue("overflow-#{direction}") changeFn(element, axisName) unless overflow == "hidden" - break unless (element[axisName] == oldScrollValue && element != document.body) - lastElement = element + break unless element[axisName] == oldScrollValue && element != document.body # we may have an orphaned element. if so, just scroll the body element. element = element.parentElement || document.body -- cgit v1.2.3