From 810dafcb7c4d76bf0bebfab12bbb869e0e19bd3a Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Tue, 19 Apr 2016 09:26:50 +0100 Subject: Help dialog; remove ability to blur the dialog. Previously, you could blur the help dialog on the options page (to read and type command names). With the reinstated help-dialog styling (whereby the help-dialog iframe extends across the entire window), this doesn't make sense. So it's removed. --- content_scripts/ui_component.coffee | 2 +- content_scripts/vimium_frontend.coffee | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'content_scripts') diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee index 7422aada..59e4fe41 100644 --- a/content_scripts/ui_component.coffee +++ b/content_scripts/ui_component.coffee @@ -56,7 +56,7 @@ class UIComponent false # We will not be calling sendResponse. # If this frame receives the focus, then hide the UI component. window.addEventListener "focus", (event) => - if event.target == window and @options?.focus and not @options?.allowBlur + if event.target == window and @options?.focus @hide false true # Continue propagating the event. # Set the iframe's port, thereby rendering the UI component ready. diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index a80093f9..68cd402d 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -630,10 +630,8 @@ window.HelpDialog ?= if @isShowing() @helpUI.hide() else - # On the options page, we allow the help dialog to blur, elsewhere we do not. This allows users to view - # the help dialog while typing in the key-mappings input. @helpUI.activate extend request, - name: "activate", focus: true, allowBlur: window.isVimiumOptionsPage ? false + name: "activate", focus: true initializePreDomReady() DomUtils.documentReady initializeOnDomReady -- cgit v1.2.3