From 64d8c34a628d142400abb8f417a1f9d48220e60c Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Sat, 2 Apr 2016 06:15:09 +0100 Subject: Wait for docomentReady to generate hints. If document.documentElement isn't ready, then we can'r generate hints. Moreover, this would crash -- thereby hanging global link hints. --- content_scripts/link_hints.coffee | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'content_scripts') diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index 0295aa3e..af29b435 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -119,7 +119,7 @@ class LinkHintsMode tabCount: 0 constructor: (hintDescriptors, mode = OPEN_IN_CURRENT_TAB) -> - # we need documentElement to be ready in order to append links + # We need documentElement to be ready in order to append links. return unless document.documentElement if mode in [COPY_LINK_URL, OPEN_INCOGNITO] @@ -610,6 +610,8 @@ LocalHints = # element. # getLocalHints: -> + # We need documentElement to be ready in order to find links. + return [] unless document.documentElement elements = document.documentElement.getElementsByTagName "*" visibleElements = [] -- cgit v1.2.3