From 5307f07729f2a35debbee6ef8c5f09493a8b81bf Mon Sep 17 00:00:00 2001 From: gdh1995 Date: Sun, 28 Oct 2018 11:53:27 +0800 Subject: fix a small typo that attachShadow needs an argument --- content_scripts/ui_component.coffee | 3 ++- content_scripts/vimium_frontend.coffee | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'content_scripts') diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee index f0815d08..d3145eb3 100644 --- a/content_scripts/ui_component.coffee +++ b/content_scripts/ui_component.coffee @@ -27,7 +27,8 @@ class UIComponent seamless: "seamless" shadowWrapper = DomUtils.createElement "div" # PhantomJS doesn't support createShadowRoot, so guard against its non-existance. - @shadowDOM = shadowWrapper.attachShadow?() ? shadowWrapper.createShadowRoot?() ? shadowWrapper + @shadowDOM = shadowWrapper.attachShadow?( mode: "open" ) ? + shadowWrapper.createShadowRoot?() ? shadowWrapper @shadowDOM.appendChild styleSheet @shadowDOM.appendChild @iframeElement @toggleIframeElementClasses "vimiumUIComponentVisible", "vimiumUIComponentHidden" diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index 2eb4a0cd..0f5d05f2 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -247,7 +247,7 @@ flashFrame = do -> # PhantomJS doesn't support createShadowRoot, so guard against its non-existance. # https://hacks.mozilla.org/2018/10/firefox-63-tricks-and-treats/ says # Firefox 63 has enabled Shadow DOM v1 by default - _shadowDOM = highlightedFrameElement.attachShadow?() ? + _shadowDOM = highlightedFrameElement.attachShadow?( mode: "open" ) ? highlightedFrameElement.createShadowRoot?() ? highlightedFrameElement # Inject stylesheet. -- cgit v1.2.3