From 3f3f256e1abe2a7795ba89ff6b84d4b81fb0a7e2 Mon Sep 17 00:00:00 2001
From: Stephen Blott
Date: Thu, 20 Nov 2014 17:15:22 +0000
Subject:  Do not handle keystrokes for contentEditable (check find mode).

 It is not strictly necessary to check find mode here.  However, if we
 don't do so, then we leave a booby trap for future developers.  So we
 do the extra check.  This, hopefully, means that we don't suddenly find
 ourselves dropping into insert mode just because somebody reorders the
 code elsewhere.
---
 content_scripts/vimium_frontend.coffee | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'content_scripts')

diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee
index 58224f89..a98b6254 100644
--- a/content_scripts/vimium_frontend.coffee
+++ b/content_scripts/vimium_frontend.coffee
@@ -567,8 +567,7 @@ isInsertMode = ->
   # Some sites (e.g. inbox.google.com) change the contentEditable attribute on the fly (see #1245); and
   # unfortunately, isEditable() is called *before* the change is made.  Therefore, we need to re-check whether
   # the active element is contentEditable.
-  document.activeElement and
-    document.activeElement.isContentEditable and
+  document.activeElement and document.activeElement.isContentEditable and !findMode and
     enterInsertModeWithoutShowingIndicator document.activeElement
 
 # should be called whenever rawQuery is modified.
-- 
cgit v1.2.3