From 3b9508d4b4ce27acd2182d793467e748c815fe94 Mon Sep 17 00:00:00 2001
From: mrmr1993
Date: Sun, 10 May 2015 00:36:27 +0100
Subject: Disable UIComponent for XML documents

If the page is an XML document, nothing we do works:
* <style> elements show their contents inline,
* <iframe> elements don't load any content,
* document.createElement generates elements that
  - have Element.style == null, and
  - ignore CSS.

This commit stops us from injecting anything into the DOM from
UIComponent, fixing #1640.
---
 content_scripts/ui_component.coffee | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'content_scripts')

diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee
index ba141b23..5bb13496 100644
--- a/content_scripts/ui_component.coffee
+++ b/content_scripts/ui_component.coffee
@@ -7,6 +7,14 @@ class UIComponent
 
   constructor: (iframeUrl, className, @handleMessage) ->
     styleSheet = document.createElement "style"
+
+    # If this is an XML document, nothing we do here works:
+    # * <style> elements show their contents inline,
+    # * <iframe> elements don't load any content,
+    # * document.createElement generates elements that have style == null and ignore CSS.
+    # We bail here if this is the case so we're polluting the DOM to no or negative effect.
+    return unless styleSheet.style
+
     styleSheet.type = "text/css"
     # Default to everything hidden while the stylesheet loads.
     styleSheet.innerHTML = "@import url(\"#{chrome.runtime.getURL("content_scripts/vimium.css")}\");"
-- 
cgit v1.2.3