From 328ebe9f0c49f0d48cff07280ee7bd8da21d3476 Mon Sep 17 00:00:00 2001
From: Phil Crosby
Date: Sat, 16 Aug 2014 16:52:28 -0700
Subject: Add comments as to why we should stop propagating the keyup event

---
 content_scripts/vimium_frontend.coffee | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'content_scripts')

diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee
index b66a7990..c7e5f2ef 100644
--- a/content_scripts/vimium_frontend.coffee
+++ b/content_scripts/vimium_frontend.coffee
@@ -433,10 +433,10 @@ onKeydown = (event) ->
       isValidFirstKey(KeyboardUtils.getKeyChar(event))))
     event.stopPropagation()
 
-onKeyup = (event) -> 
-  return unless handlerStack.bubbleEvent('keyup', event)
-  if (!isInsertMode())
-    event.stopPropagation();
+onKeyup = (event) ->
+  return unless handlerStack.bubbleEvent("keyup", event)
+  # Don't propagate the keyup to the underlying page, since Vimium has handled it. See #733.
+  event.stopPropagation() unless isInsertMode()
 
 checkIfEnabledForUrl = ->
   url = window.location.toString()
-- 
cgit v1.2.3