From 31aa6c37794872b9341d8a30f17e72cda373ba59 Mon Sep 17 00:00:00 2001
From: mrmr1993
Date: Wed, 3 Feb 2016 15:46:24 +0000
Subject: Fix closing the help dialog

---
 content_scripts/vimium_frontend.coffee | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

(limited to 'content_scripts')

diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee
index fdfef910..bfc09980 100644
--- a/content_scripts/vimium_frontend.coffee
+++ b/content_scripts/vimium_frontend.coffee
@@ -768,19 +768,17 @@ window.enterFindMode = ->
   Marks.setPreviousPosition()
   new FindMode()
 
-window.HelpDialog =
+# If we are in the help dialog iframe, HelpDialog is already defined with the necessary functions.
+window.HelpDialog ?=
   helpUI: null
   container: null
   showing: false
 
-  # This setting is pulled out of local storage. It's false by default.
-  getShowAdvancedCommands: -> Settings.get("helpDialog_showAdvancedCommands")
-
   init: ->
     return if @helpUI?
 
     @helpUI = new UIComponent "pages/help_dialog.html", "vimiumHelpDialogFrame", (event) =>
-      @helpUI.hide() if event.data == "hide"
+      @hide() if event.data == "hide"
 
   isReady: -> @helpUI?
 
-- 
cgit v1.2.3