From 46fe5cffc952b80371f839fce0aa2fc8ded27f50 Mon Sep 17 00:00:00 2001
From: mrmr1993
Date: Wed, 26 Aug 2015 18:21:27 +0100
Subject: Use createElementNS for XML documents and remove XML specific
 codepaths

This implements @gdh1995's idea from #1796.
---
 content_scripts/ui_component.coffee | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

(limited to 'content_scripts/ui_component.coffee')

diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee
index e4cfc293..a5be78fc 100644
--- a/content_scripts/ui_component.coffee
+++ b/content_scripts/ui_component.coffee
@@ -6,28 +6,17 @@ class UIComponent
   shadowDOM: null
 
   constructor: (iframeUrl, className, @handleMessage) ->
-    styleSheet = document.createElement "style"
-
-    unless styleSheet.style
-      # If this is an XML document, nothing we do here works:
-      # * <style> elements show their contents inline,
-      # * <iframe> elements don't load any content,
-      # * document.createElement generates elements that have style == null and ignore CSS.
-      # If this is the case we don't want to pollute the DOM to no or negative effect.  So we bail
-      # immediately, and disable all externally-called methods.
-      @postMessage = @activate = @show = @hide = ->
-        console.log "This vimium feature is disabled because it is incompatible with this page."
-      return
+    styleSheet = DomUtils.createElement "style"
 
     styleSheet.type = "text/css"
     # Default to everything hidden while the stylesheet loads.
     styleSheet.innerHTML = "@import url(\"#{chrome.runtime.getURL("content_scripts/vimium.css")}\");"
 
-    @iframeElement = document.createElement "iframe"
+    @iframeElement = DomUtils.createElement "iframe"
     extend @iframeElement,
       className: className
       seamless: "seamless"
-    shadowWrapper = document.createElement "div"
+    shadowWrapper = DomUtils.createElement "div"
     # PhantomJS doesn't support createShadowRoot, so guard against its non-existance.
     @shadowDOM = shadowWrapper.createShadowRoot?() ? shadowWrapper
     @shadowDOM.appendChild styleSheet
-- 
cgit v1.2.3


From da8653f303015f0780fe3270a2ec8db60316d29e Mon Sep 17 00:00:00 2001
From: gdh1995
Date: Fri, 28 Aug 2015 21:10:04 +0800
Subject: clean code

---
 content_scripts/ui_component.coffee | 1 -
 1 file changed, 1 deletion(-)

(limited to 'content_scripts/ui_component.coffee')

diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee
index a5be78fc..d935079d 100644
--- a/content_scripts/ui_component.coffee
+++ b/content_scripts/ui_component.coffee
@@ -7,7 +7,6 @@ class UIComponent
 
   constructor: (iframeUrl, className, @handleMessage) ->
     styleSheet = DomUtils.createElement "style"
-
     styleSheet.type = "text/css"
     # Default to everything hidden while the stylesheet loads.
     styleSheet.innerHTML = "@import url(\"#{chrome.runtime.getURL("content_scripts/vimium.css")}\");"
-- 
cgit v1.2.3