From 359fbbbcd286f16de5b23db5f4bb8dbbb2b5b6ac Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Fri, 9 Jan 2015 09:09:19 +0000 Subject: Modes; fix click handling for all "overlay" modes. From #1413... Go here: http://jsfiddle.net/smblott/9u7geasd/ In the result window: Type /Fish (do not press enter). Click in one of the text areas. Press Esc. Type aaa - you're in insert mode. Type jk - hmm, where did they go? Type o - oops, you're also in normal mode. --- content_scripts/mode_find.coffee | 8 -------- 1 file changed, 8 deletions(-) (limited to 'content_scripts/mode_find.coffee') diff --git a/content_scripts/mode_find.coffee b/content_scripts/mode_find.coffee index 2ef74a89..40245d14 100644 --- a/content_scripts/mode_find.coffee +++ b/content_scripts/mode_find.coffee @@ -47,13 +47,5 @@ class PostFindMode extends InsertModeBlocker blur: (event) => @alwaysContinueBubbling => @exit() keydown: (event) => @alwaysContinueBubbling => @exit() if document.activeElement != element - # If element is selectable, then it's already focused. If the user clicks on it, then there's no new - # focus event, so InsertModeTrigger doesn't fire and we don't drop automatically into insert mode. So - # we have to handle this case separately. - click: (event) => - @alwaysContinueBubbling => - new InsertMode element if DomUtils.isDOMDescendant element, event.target - @exit() - root = exports ? window root.PostFindMode = PostFindMode -- cgit v1.2.3