From ca0622f1ebbe79230bedf3a1b2bf716f9d66b840 Mon Sep 17 00:00:00 2001 From: ilya Date: Tue, 9 Mar 2010 20:02:37 -0800 Subject: Fix a bug where if you add a mapping, save, and then remove it -- it won't get actually unmapped. --- commands.js | 88 ++++++++++++++++++++++++++++++++----------------------------- 1 file changed, 46 insertions(+), 42 deletions(-) (limited to 'commands.js') diff --git a/commands.js b/commands.js index 7e118cd0..3040cde0 100644 --- a/commands.js +++ b/commands.js @@ -51,6 +51,52 @@ function parseCustomKeyMappings(customKeyMappings) { } } +function clearKeyMappingsAndSetDefaults() { + keyToCommandRegistry = {}; + + mapKeyToCommand('?', 'showHelp'); + mapKeyToCommand('j', 'scrollDown'); + mapKeyToCommand('k', 'scrollUp'); + mapKeyToCommand('h', 'scrollLeft'); + mapKeyToCommand('l', 'scrollRight'); + mapKeyToCommand('gg', 'scrollToTop'); + mapKeyToCommand('G', 'scrollToBottom'); + mapKeyToCommand('', 'scrollDown'); + mapKeyToCommand('', 'scrollUp'); + mapKeyToCommand('', 'scrollPageDown'); + mapKeyToCommand('', 'scrollPageUp'); + mapKeyToCommand('', 'scrollFullPageDown'); + mapKeyToCommand('', 'scrollFullPageUp'); + mapKeyToCommand('r', 'reload'); + mapKeyToCommand('gf', 'toggleViewSource'); + + mapKeyToCommand('i', 'enterInsertMode'); + + mapKeyToCommand('H', 'goBack'); + mapKeyToCommand('L', 'goForward'); + + mapKeyToCommand('zi', 'zoomIn'); + mapKeyToCommand('zo', 'zoomOut'); + + mapKeyToCommand('f', 'activateLinkHintsMode'); + mapKeyToCommand('F', 'activateLinkHintsModeToOpenInNewTab'); + + mapKeyToCommand('/', 'enterFindMode'); + mapKeyToCommand('n', 'performFind'); + mapKeyToCommand('N', 'performBackwardsFind'); + + mapKeyToCommand('yy', 'copyCurrentUrl'); + + mapKeyToCommand('K', 'nextTab'); + mapKeyToCommand('J', 'previousTab'); + mapKeyToCommand('gt', 'nextTab'); + mapKeyToCommand('gT', 'previousTab'); + + mapKeyToCommand('t', 'createTab'); + mapKeyToCommand('d', 'removeTab'); + mapKeyToCommand('u', 'restoreTab'); +} + // Navigating the current page: addCommand('showHelp', 'Show help', true); addCommand('scrollDown', 'Scroll down'); @@ -105,45 +151,3 @@ var commandGroups = { tabManipulation: ["nextTab", "previousTab", "createTab", "removeTab", "restoreTab"] }; - -mapKeyToCommand('?', 'showHelp'); -mapKeyToCommand('j', 'scrollDown'); -mapKeyToCommand('k', 'scrollUp'); -mapKeyToCommand('h', 'scrollLeft'); -mapKeyToCommand('l', 'scrollRight'); -mapKeyToCommand('gg', 'scrollToTop'); -mapKeyToCommand('G', 'scrollToBottom'); -mapKeyToCommand('', 'scrollDown'); -mapKeyToCommand('', 'scrollUp'); -mapKeyToCommand('', 'scrollPageDown'); -mapKeyToCommand('', 'scrollPageUp'); -mapKeyToCommand('', 'scrollFullPageDown'); -mapKeyToCommand('', 'scrollFullPageUp'); -mapKeyToCommand('r', 'reload'); -mapKeyToCommand('gf', 'toggleViewSource'); - -mapKeyToCommand('i', 'enterInsertMode'); - -mapKeyToCommand('H', 'goBack'); -mapKeyToCommand('L', 'goForward'); - -mapKeyToCommand('zi', 'zoomIn'); -mapKeyToCommand('zo', 'zoomOut'); - -mapKeyToCommand('f', 'activateLinkHintsMode'); -mapKeyToCommand('F', 'activateLinkHintsModeToOpenInNewTab'); - -mapKeyToCommand('/', 'enterFindMode'); -mapKeyToCommand('n', 'performFind'); -mapKeyToCommand('N', 'performBackwardsFind'); - -mapKeyToCommand('yy', 'copyCurrentUrl'); - -mapKeyToCommand('K', 'nextTab'); -mapKeyToCommand('J', 'previousTab'); -mapKeyToCommand('gt', 'nextTab'); -mapKeyToCommand('gT', 'previousTab'); - -mapKeyToCommand('t', 'createTab'); -mapKeyToCommand('d', 'removeTab'); -mapKeyToCommand('u', 'restoreTab'); -- cgit v1.2.3