From fc8519e4e3a770253a35f1af7546d432f64392ea Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Thu, 28 Apr 2016 06:51:35 +0100 Subject: Make vimiumFlash a class. There are circumstances when we hav two (identical) vimiumFlash elements displayed: specifically, when using the waitForEnter keyboard blocker. So, we should use a class (rather than an id) to style the flash element. --- content_scripts/vimium.css | 2 +- lib/dom_utils.coffee | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/content_scripts/vimium.css b/content_scripts/vimium.css index 8803fd15..be9d4a65 100644 --- a/content_scripts/vimium.css +++ b/content_scripts/vimium.css @@ -382,7 +382,7 @@ iframe.vomnibarFrame { z-index: 2147483646; } -div#vimiumFlash { +div.vimiumFlash { box-shadow: 0px 0px 4px 2px #4183C4; padding: 1px; background-color: transparent; diff --git a/lib/dom_utils.coffee b/lib/dom_utils.coffee index 3d719337..b247e93b 100644 --- a/lib/dom_utils.coffee +++ b/lib/dom_utils.coffee @@ -263,8 +263,8 @@ DomUtils = addFlashRect: (rect) -> flashEl = @createElement "div" - flashEl.id = "vimiumFlash" - flashEl.className = "vimiumReset" + flashEl.classList.add "vimiumReset" + flashEl.classList.add "vimiumFlash" flashEl.style.left = rect.left + "px" flashEl.style.top = rect.top + "px" flashEl.style.width = rect.width + "px" -- cgit v1.2.3