From ea0b6f04e47668e4374c1f3a1eb95e510a5f62b3 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Tue, 12 May 2015 13:11:44 +0100 Subject: In vomnibar, excludes prompted text. This changes the behaviour of in the vomnibar when a prompted text is present (i.e. text from a suggestion which the user has not yet typed. Now, that text is no longer included in the query launched with . After a little experience, I'd say that's a pretty bad UX. This also adds a binding to launch the query with the prompted text included. --- pages/vomnibar.coffee | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pages/vomnibar.coffee b/pages/vomnibar.coffee index 7c9eef83..6485aed8 100644 --- a/pages/vomnibar.coffee +++ b/pages/vomnibar.coffee @@ -200,7 +200,10 @@ class VomnibarUI # (addPromptedText), the text in the input might not correspond to any of the completions. So we # fire off the query to the background page and use the completion at the top of the list (which # will be the right one). - window.getSelection()?.collapseToEnd() if @inputContainsASelectionRange() + # + # on its own selects only the text that the user has typed. also includes + # any prompted text. + window.getSelection()?.collapseToEnd() if @inputContainsASelectionRange() and event.ctrlKey @update true, => if @completions[0] completion = @completions[0] -- cgit v1.2.3