From e85cbd38194df9d867cc815afb99d60727d6561b Mon Sep 17 00:00:00 2001 From: Phil Crosby Date: Sat, 24 Apr 2010 14:20:43 -0700 Subject: A few comments and cleanups around the linkhints xpath --- linkHints.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/linkHints.js b/linkHints.js index f8826113..de140581 100644 --- a/linkHints.js +++ b/linkHints.js @@ -16,15 +16,17 @@ var shouldOpenLinkHintInNewTab = false; // Whether we have added to the page the CSS needed to display link hints. var linkHintsCssAdded = false; -// Generate an XPath describing what a clickable element is. +/* + * Generate an XPath describing what a clickable element is. + * The final expression will be something like "//button | //xhtml:button | ..." + */ var clickableElementsXPath = (function() { var clickableElements = ["a", "textarea", "button", "select", "input[not(@type='hidden')]"]; - var XPath = ""; - for (var i in clickableElements) { - XPath += "//" + clickableElements[i] + " | " + "//xhtml:" + clickableElements[i] + " | "; - } - XPath += "//*[@onclick]"; - return XPath; + var xpath = []; + for (var i in clickableElements) + xpath.push("//" + clickableElements[i], "//xhtml:" + clickableElements[i]); + xpath.push("//*[@onclick]"); + return xpath.join(" | ") })(); // We need this as a top-level function because our command system doesn't yet support arguments. -- cgit v1.2.3