From e81f8c7e82611d5ee7e32dec6a3a0bdc546da414 Mon Sep 17 00:00:00 2001
From: Phil Crosby
Date: Sun, 29 Apr 2012 21:33:26 -0700
Subject: Rename reverseAction and alternative to simply "open in new tab".

The genericism is not helping.
---
 background_page.html |  2 +-
 fuzzyMode.js         | 13 +++++--------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/background_page.html b/background_page.html
index 755233d2..d9873d87 100644
--- a/background_page.html
+++ b/background_page.html
@@ -247,7 +247,7 @@
    */
   function openUrlInNewTab(request) {
     chrome.tabs.getSelected(null, function(tab) {
-      chrome.tabs.create({ url: request.url, index: tab.index + 1, selected: request.selected });
+      chrome.tabs.create({ url: request.url, index: tab.index + 1, selected: true });
     });
   }
 
diff --git a/fuzzyMode.js b/fuzzyMode.js
index b6520e36..c7b5b082 100644
--- a/fuzzyMode.js
+++ b/fuzzyMode.js
@@ -9,14 +9,14 @@ var fuzzyMode = (function() {
   }
 
   /** Trigger the fuzzy mode dialog */
-  function start(name, reverseAction, refreshInterval) {
+  function start(name, refreshInterval) {
     var completer = getCompleter(name);
     if (!fuzzyBox)
       fuzzyBox = new FuzzyBox(10);
     completer.refresh();
     fuzzyBox.setCompleter(completer);
     fuzzyBox.setRefreshInterval(refreshInterval);
-    fuzzyBox.show(reverseAction);
+    fuzzyBox.show();
   }
 
   /** User interface for fuzzy completion */
@@ -36,8 +36,7 @@ var fuzzyMode = (function() {
       this.refreshInterval = refreshInterval;
     },
 
-    show: function(reverseAction) {
-      this.reverseAction = reverseAction;
+    show: function() {
       this.box.style.display = 'block';
       this.input.focus();
       handlerStack.push({ keydown: this.onKeydown.bind(this) });
@@ -97,10 +96,8 @@ var fuzzyMode = (function() {
       // (opening in new tab)
       else if (event.keyCode == keyCodes.enter) {
         this.update(true, function() {
-          var alternative = (event.shiftKey || isPrimaryModifierKey(event));
-          if (self.reverseAction)
-            alternative = !alternative;
-          self.completions[self.selection].action[alternative ? 1 : 0]();
+          var openInNewTab = (event.shiftKey || isPrimaryModifierKey(event));
+          self.completions[self.selection].action[openInNewTab ? 1 : 0]();
           self.hide();
         });
       }
-- 
cgit v1.2.3