From d6b3845a8a9d7604bad7f1a24d87c39bdc116125 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Sat, 17 Sep 2016 08:03:25 +0100 Subject: Tweaks to comments. --- background_scripts/marks.coffee | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/background_scripts/marks.coffee b/background_scripts/marks.coffee index 963b8925..dbc14671 100644 --- a/background_scripts/marks.coffee +++ b/background_scripts/marks.coffee @@ -64,7 +64,8 @@ Marks = # or we create a new tab. focusOrLaunch: (markInfo, req) -> # If we're not going to be scrolling to a particular position in the tab, then we choose all tabs with a - # matching URL prefix. Otherwise, we require an exact match. + # matching URL prefix. Otherwise, we require an exact match (because it doesn't make sense to scroll + # unless there's an exact URL match). query = if markInfo.scrollX == markInfo.scrollY == 0 then "#{markInfo.url}*" else markInfo.url chrome.tabs.query { url: query }, (tabs) => if 0 < tabs.length @@ -85,7 +86,8 @@ Marks = # Prefer tabs in the current window, if there are any. tabsInWindow = tabs.filter (tab) -> tab.windowId == id tabs = tabsInWindow if 0 < tabsInWindow.length - # If more than one tab remains and the current tab remains a conadidate, then pick another one. + # If more than one tab remains and the current tab is still a candidate, then don't pick the current + # tab (because jumping to it does nothing). tabs = (tab for tab in tabs when not tab.active) if 1 < tabs.length # Prefer shorter URLs. tabs.sort (a,b) -> a.url.length - b.url.length -- cgit v1.2.3