From caca2b6e81ba6fcad9cdc406c8cde15084db7539 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Wed, 22 Apr 2015 12:24:54 +0100 Subject: Filter out non-HREF elements for "yf". If the element does not have an HREF, then we shouldn't be offering to copy it's link. --- content_scripts/link_hints.coffee | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index 5404d177..650080d4 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -56,7 +56,10 @@ LinkHints = return @isActive = true - hintMarkers = (@createMarkerFor(el) for el in @getVisibleClickableElements()) + elements = @getVisibleClickableElements() + # For COPY_LINK_URL mode, we filter out those elements which don't have an HREF to copy. + elements = (el for el in elements when el.element.href?) if mode == COPY_LINK_URL + hintMarkers = (@createMarkerFor(el) for el in elements) @getMarkerMatcher().fillInMarkers(hintMarkers) @hintMode = new Mode -- cgit v1.2.3