From aa35d7fe5eae257bc67e13f2f8d3f06442d428c7 Mon Sep 17 00:00:00 2001
From: Stephen Blott
Date: Sun, 13 Mar 2016 14:31:50 +0000
Subject: Tweak options page class names...

We were using the class name exclusionRemoveButton for the `td`
containing the button to remove exclusion rules on the options page.

Because of this, we were (correctly) picking up the button itself as
clickable, but incorrectly picking up also its enclosing `td` (which
isn't actually clickable at all).  The effect was to always have two
hint labels over the remove button.

This was happening simply because we have the text "button" in the class
name.  So, here, we just rename the classes.
---
 pages/exclusions.html | 2 +-
 pages/options.coffee  | 2 +-
 pages/options.css     | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pages/exclusions.html b/pages/exclusions.html
index b09f2895..c6647cea 100644
--- a/pages/exclusions.html
+++ b/pages/exclusions.html
@@ -8,6 +8,6 @@
    <tr class="exclusionRuleTemplateInstance">
       <td><input/ type="text" class="pattern" spellcheck="false" placeholder="URL pattern"></td>
       <td class="exclusionRulePassKeys"><input/ type="text" class="passKeys" spellcheck="false" placeholder="Exclude keys"></td>
-      <td class="exclusionRemoveButton"><input/ type="button" class="exclusionRemoveButtonButton" value="&#x2716;"></td>
+      <td class="exclusionRemove"><input/ type="button" class="exclusionRemoveButton" value="&#x2716;"></td>
    </tr>
 </template>
diff --git a/pages/options.coffee b/pages/options.coffee
index a82c3807..6070400e 100644
--- a/pages/options.coffee
+++ b/pages/options.coffee
@@ -125,7 +125,7 @@ class ExclusionRulesOption extends Option
   # Accessors for the three main sub-elements of an "exclusionRuleTemplateInstance".
   getPattern: (element) -> element.querySelector(".pattern")
   getPassKeys: (element) -> element.querySelector(".passKeys")
-  getRemoveButton: (element) -> element.querySelector(".exclusionRemoveButtonButton")
+  getRemoveButton: (element) -> element.querySelector(".exclusionRemoveButton")
 
 # ExclusionRulesOnPopupOption is ExclusionRulesOption, extended with some UI tweeks suitable for use in the
 # page popup.  This also differs from ExclusionRulesOption in that, on the page popup, there is always a URL
diff --git a/pages/options.css b/pages/options.css
index 75bbe159..490ae164 100644
--- a/pages/options.css
+++ b/pages/options.css
@@ -181,15 +181,15 @@ td.booleanOption { font-size: 12px; }
 .exclusionRulePassKeys {
   width: 33%;
 }
-.exclusionRemoveButton {
+.exclusionRemove {
   width: 1px; /* 1px; smaller than the button itself. */
 }
-.exclusionRemoveButtonButton {
+.exclusionRemoveButton {
   border: none;
   background-color: #fff;
   color: #979ca0;
 }
-.exclusionRemoveButtonButton:hover {
+.exclusionRemoveButton:hover {
   color: #444;
 }
 input.pattern, input.passKeys, .exclusionHeaderText {
-- 
cgit v1.2.3