From 9e8a48457d7bc2939278cc9764c23ad788ac95e7 Mon Sep 17 00:00:00 2001 From: mrmr1993 Date: Wed, 5 Nov 2014 15:25:15 +0000 Subject: Disable scrolling for `overflow: hidden` elements --- content_scripts/scroller.coffee | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content_scripts/scroller.coffee b/content_scripts/scroller.coffee index f3c632b3..8eb50d77 100644 --- a/content_scripts/scroller.coffee +++ b/content_scripts/scroller.coffee @@ -38,7 +38,9 @@ ensureScrollChange = (direction, changeFn) -> element = activatedElement loop oldScrollValue = element[axisName] - changeFn(element, axisName) + overflow = window.getComputedStyle(element, null).getPropertyValue("overflow-#{direction}") + # Elements with `overflow: hidden` don't natively have scrolling, so we shouldn't scroll them. + changeFn(element, axisName) unless overflow == "hidden" break unless (element[axisName] == oldScrollValue && element != document.body) lastElement = element # we may have an orphaned element. if so, just scroll the body element. -- cgit v1.2.3