From 99c8eb517b89a7c1acc4d4f28dde1ce6f5c7713f Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Sat, 22 Aug 2015 11:50:36 +0100 Subject: Prevent perpetual scroll. If we miss the keyup event while a smooth scroll is active (because the focus changes), then we scroll forever. This stops scrolling on blur. Fixes #1788. --- content_scripts/scroller.coffee | 3 +++ 1 file changed, 3 insertions(+) diff --git a/content_scripts/scroller.coffee b/content_scripts/scroller.coffee index 81c71fcd..271a7854 100644 --- a/content_scripts/scroller.coffee +++ b/content_scripts/scroller.coffee @@ -136,6 +136,9 @@ CoreScroller = handlerStack.alwaysContinueBubbling => @keyIsDown = false @time += 1 + blur: => + handlerStack.alwaysContinueBubbling => + @time += 1 if event.target == window # Return true if CoreScroller would not initiate a new scroll right now. wouldNotInitiateScroll: -> @lastEvent?.repeat and Settings.get "smoothScroll" -- cgit v1.2.3