From 14676a23c96b86eb7bcfbcc5730cefe15efd5735 Mon Sep 17 00:00:00 2001
From: Phil Crosby
Date: Mon, 19 Apr 2010 09:28:23 -0700
Subject: Pull the version number from the manifest file instead of hard coding
 it

---
 background_page.html | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/background_page.html b/background_page.html
index 4c328a20..e2252b4d 100644
--- a/background_page.html
+++ b/background_page.html
@@ -2,9 +2,12 @@
 <head>
 <script type="text/javascript" src="commands.js"/>
 <script type="text/javascript" charset="utf-8">
-  // Currently we need to remember to change this each time we push. Chromium #15242 will enable us
-  // to retrieve this programmatically.
-  var currentVersion = "1.16";
+  // Chromium #15242 will make this XHR request unnecessary.
+  var manifestRequest = new XMLHttpRequest();
+  manifestRequest.open("GET", chrome.extension.getURL("manifest.json"), false);
+  manifestRequest.send(null);
+
+  var currentVersion = JSON.parse(manifestRequest.responseText).version;
 
   var tabQueue = {}; // windowId -> Array
   var openTabs = {}; // tabId -> object with various tab properties
@@ -316,7 +319,7 @@
     openTabs[tab.id].scrollX = scrollX;
     openTabs[tab.id].scrollY = scrollY;
   }
-  
+
 
   chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab) {
     if (changeInfo.status != "loading") { return; } // only do this once per URL change
-- 
cgit v1.2.3


From 887fac79eac4bca3c6d0b232b91b6e581135fb09 Mon Sep 17 00:00:00 2001
From: Phil Crosby
Date: Sat, 24 Apr 2010 02:01:50 -0700
Subject: Specify a table-layout of auto; this fixes the help dialog's
 appearance on gamefaqs.com

---
 helpDialog.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helpDialog.html b/helpDialog.html
index 0587145d..557cfb69 100644
--- a/helpDialog.html
+++ b/helpDialog.html
@@ -30,7 +30,7 @@
       float:left;
     }
     .vimiumColumn table, .vimiumColumn td, .vimiumColumn tr { padding:0; margin:0; }
-    .vimiumColumn table { width:100%; }
+    .vimiumColumn table { width:100%; table-layout:auto; }
     .vimiumColumn td { vertical-align:top; padding:1px; }
     #vimiumHelpDialog .vimiumColumn tr > td:first-of-type {
       text-align:right;
-- 
cgit v1.2.3


From aa948ff92d772083c346a1390b600c4127b0515d Mon Sep 17 00:00:00 2001
From: Phil Crosby
Date: Sat, 24 Apr 2010 02:03:37 -0700
Subject: Override all background colors in the help dialog. Fixes wikipedia
 and closes #95.

---
 helpDialog.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/helpDialog.html b/helpDialog.html
index 557cfb69..16007f13 100644
--- a/helpDialog.html
+++ b/helpDialog.html
@@ -4,7 +4,7 @@
 -->
 <div id="vimiumHelpDialog">
   <style>
-    #vimiumHelpDialog * { font-size:12px; line-height:130%; color:black; }
+    #vimiumHelpDialog * { font-size:12px; line-height:130%; color:black; background-color:transparent; }
     #vimiumHelpDialog {
       text-align:left;
       border:3px solid red;
-- 
cgit v1.2.3


From f84d189e2dab185f61c2bf7c812de56a25cf4f7e Mon Sep 17 00:00:00 2001
From: int3
Date: Sun, 25 Apr 2010 06:23:00 +0800
Subject: Add link hints support for XHTML

---
 linkHints.js | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/linkHints.js b/linkHints.js
index 6c4fb3d0..d2acb837 100644
--- a/linkHints.js
+++ b/linkHints.js
@@ -16,9 +16,13 @@ var shouldOpenLinkHintInNewTab = false;
 // Whether we have added to the page the CSS needed to display link hints.
 var linkHintsCssAdded = false;
 
-// An XPath describing what a clickable element is. We could also look for images with an onclick
-// attribute, but let's wait to see if that really is necessary.
-var clickableElementsXPath = "//a | //textarea | //button | //select | //input[not(@type='hidden')] | //*[@onclick]";
+// Generate an XPath describing what a clickable element is.
+var clickableElements = ["a", "textarea", "button", "select", "input[not(@type='hidden')]"];
+var clickableElementsXPath = "";
+for (var i in clickableElements) {
+  clickableElementsXPath += "//" + clickableElements[i]  + " | " + "//xhtml:" + clickableElements[i] + " | ";
+}
+clickableElementsXPath += "//*[@onclick]";
 
 // We need this as a top-level function because our command system doesn't yet support arguments.
 function activateLinkHintsModeToOpenInNewTab() { activateLinkHintsMode(true); }
@@ -66,7 +70,10 @@ function logXOfBase(x, base) { return Math.log(x) / Math.log(base); }
  * of digits needed to enumerate all of the links on screen.
  */
 function getVisibleClickableElements() {
-  var resultSet = document.evaluate(clickableElementsXPath, document.body, null,
+  var resultSet = document.evaluate(clickableElementsXPath, document.body,
+    function (namespace) {
+      return namespace == "xhtml" ? "http://www.w3.org/1999/xhtml" : null;
+    },
     XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);
   var visibleElements = [];
 
-- 
cgit v1.2.3


From a741c8cd05566261ba20250cc3fbdfdb323b29a0 Mon Sep 17 00:00:00 2001
From: int3
Date: Sun, 25 Apr 2010 06:37:51 +0800
Subject: Encapsulate the generation of clickableElementsXPath

---
 linkHints.js | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/linkHints.js b/linkHints.js
index d2acb837..f8826113 100644
--- a/linkHints.js
+++ b/linkHints.js
@@ -17,12 +17,15 @@ var shouldOpenLinkHintInNewTab = false;
 var linkHintsCssAdded = false;
 
 // Generate an XPath describing what a clickable element is.
-var clickableElements = ["a", "textarea", "button", "select", "input[not(@type='hidden')]"];
-var clickableElementsXPath = "";
-for (var i in clickableElements) {
-  clickableElementsXPath += "//" + clickableElements[i]  + " | " + "//xhtml:" + clickableElements[i] + " | ";
-}
-clickableElementsXPath += "//*[@onclick]";
+var clickableElementsXPath = (function() {
+  var clickableElements = ["a", "textarea", "button", "select", "input[not(@type='hidden')]"];
+  var XPath = "";
+  for (var i in clickableElements) {
+    XPath += "//" + clickableElements[i]  + " | " + "//xhtml:" + clickableElements[i] + " | ";
+  }
+  XPath += "//*[@onclick]";
+  return XPath;
+})();
 
 // We need this as a top-level function because our command system doesn't yet support arguments.
 function activateLinkHintsModeToOpenInNewTab() { activateLinkHintsMode(true); }
-- 
cgit v1.2.3


From e85cbd38194df9d867cc815afb99d60727d6561b Mon Sep 17 00:00:00 2001
From: Phil Crosby
Date: Sat, 24 Apr 2010 14:20:43 -0700
Subject: A few comments and cleanups around the linkhints xpath

---
 linkHints.js | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/linkHints.js b/linkHints.js
index f8826113..de140581 100644
--- a/linkHints.js
+++ b/linkHints.js
@@ -16,15 +16,17 @@ var shouldOpenLinkHintInNewTab = false;
 // Whether we have added to the page the CSS needed to display link hints.
 var linkHintsCssAdded = false;
 
-// Generate an XPath describing what a clickable element is.
+/* 
+ * Generate an XPath describing what a clickable element is.
+ * The final expression will be something like "//button | //xhtml:button | ..."
+ */
 var clickableElementsXPath = (function() {
   var clickableElements = ["a", "textarea", "button", "select", "input[not(@type='hidden')]"];
-  var XPath = "";
-  for (var i in clickableElements) {
-    XPath += "//" + clickableElements[i]  + " | " + "//xhtml:" + clickableElements[i] + " | ";
-  }
-  XPath += "//*[@onclick]";
-  return XPath;
+  var xpath = [];
+  for (var i in clickableElements)
+    xpath.push("//" + clickableElements[i], "//xhtml:" + clickableElements[i]);
+  xpath.push("//*[@onclick]");
+  return xpath.join(" | ")
 })();
 
 // We need this as a top-level function because our command system doesn't yet support arguments.
-- 
cgit v1.2.3

