From 86af6cda930bf1d9fa57e26612b1bb57f3594ac8 Mon Sep 17 00:00:00 2001
From: jez
Date: Sun, 16 Jan 2011 13:12:58 +0800
Subject: Refactor hint positioning tests

---
 test_harnesses/automated.html | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/test_harnesses/automated.html b/test_harnesses/automated.html
index 31a25823..ec2a229a 100644
--- a/test_harnesses/automated.html
+++ b/test_harnesses/automated.html
@@ -76,20 +76,18 @@
           }),
 
           should("position items correctly", function() {
+            function assertStartPosition(element1, element2) {
+              assert.equal(element1.getClientRects()[0].left, element2.getClientRects()[0].left);
+              assert.equal(element1.getClientRects()[0].top, element2.getClientRects()[0].top);
+            }
             stub(document.body, "style", "static");
             linkHints.activateMode();
-            function testPositions() {
-              for (var i = 0; i < 2; i++) {
-                assert.equal(document.getElementById((i+1).toString()).getClientRects()[0].left,
-                    linkHints.hintMarkers[i].getClientRects()[0].left);
-                assert.equal(document.getElementById((i+1).toString()).getClientRects()[0].top,
-                    linkHints.hintMarkers[i].getClientRects()[0].top);
-              }
-            }
-            testPositions();
+            assertStartPosition(document.getElementsByTagName("a")[0], linkHints.hintMarkers[0]);
+            assertStartPosition(document.getElementsByTagName("a")[1], linkHints.hintMarkers[1]);
             stub(document.body.style, "position", "relative");
             linkHints.resetMode();
-            testPositions();
+            assertStartPosition(document.getElementsByTagName("a")[0], linkHints.hintMarkers[0]);
+            assertStartPosition(document.getElementsByTagName("a")[1], linkHints.hintMarkers[1]);
             linkHints.deactivateMode();
           })
 
-- 
cgit v1.2.3