From ae59d3fa7ec288832bd8a0e6b41428e66b5ab1e0 Mon Sep 17 00:00:00 2001
From: Peter Parks
Date: Mon, 31 Oct 2011 20:45:46 -0700
Subject: In response to issue 363 I Adjusted the CSS for
.internalVimiumHintMarker for greater specificity so linkhints won't be so
easily tampered with by the sites CSS.
---
background_page.html | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/background_page.html b/background_page.html
index 51f9d462..7b14f11b 100644
--- a/background_page.html
+++ b/background_page.html
@@ -51,20 +51,23 @@
'.internalVimiumHintMarker {' +
'position:absolute;' +
'background-color:yellow;' +
- 'color:black;' +
- 'font-weight:bold;' +
- 'font-size:12px;' +
'padding:0 1px;' +
- 'line-height:100%;' +
'width:auto;' +
'display:block;' +
'border:1px solid #E3BE23;' +
'z-index:99999999;' +
- 'font-family:"Helvetica Neue", "Helvetica", "Arial", "Sans";' +
'top:-1px;' +
'left:-1px;' +
'white-space:nowrap;' +
'}' +
+ 'div .internalVimiumHintMarker span {' +
+ 'color: black;' +
+ 'font-weight: bold;' +
+ 'font-size: 12px;' +
+ 'font-style: normal;' +
+ 'line-height: 100%;' +
+ 'font-family: "Helvetica Neue", "Helvetica", "Arial", "Sans";' +
+ '}' +
'.internalVimiumHintMarker > .matchingCharacter {' +
'color:#C79F0B;' +
'}';
--
cgit v1.2.3
From d8342ce8bef66c882f197c64189dacc45d3b38c5 Mon Sep 17 00:00:00 2001
From: Peter Parks
Date: Tue, 1 Nov 2011 15:57:27 -0700
Subject: Added additional css properties to span definition that could
possibly be overwritten by websites.
---
background_page.html | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/background_page.html b/background_page.html
index 7b14f11b..c0332d7f 100644
--- a/background_page.html
+++ b/background_page.html
@@ -60,13 +60,23 @@
'left:-1px;' +
'white-space:nowrap;' +
'}' +
- 'div .internalVimiumHintMarker span {' +
+ '.internalVimiumHintMarker span {' +
'color: black;' +
+ 'text-decoration: none;' +
'font-weight: bold;' +
'font-size: 12px;' +
'font-style: normal;' +
+ 'letter-spacing: 0;' +
+ 'text-transform: none;' +
+ 'text-align: left;' +
+ 'text-indent: 0;' +
'line-height: 100%;' +
'font-family: "Helvetica Neue", "Helvetica", "Arial", "Sans";' +
+ 'padding: 0;' +
+ 'margin: 0;' +
+ 'float: none;' +
+ 'border: none;' +
+ 'background: none;' +
'}' +
'.internalVimiumHintMarker > .matchingCharacter {' +
'color:#C79F0B;' +
--
cgit v1.2.3
From 2f6f875a68ab3d312c570010d6902ede8508627a Mon Sep 17 00:00:00 2001
From: Peter Parks
Date: Tue, 1 Nov 2011 22:16:04 -0700
Subject: Changed the default settings for css links options page. Includes the
new declaration for span and entries for the properties users are most likely
to want to change to make it easier to know where their changes should be
applied.
---
background_page.html | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/background_page.html b/background_page.html
index c0332d7f..ada4b70c 100644
--- a/background_page.html
+++ b/background_page.html
@@ -29,7 +29,8 @@
linkHintCharacters: "sadfjklewcmpgh",
filterLinkHints: false,
userDefinedLinkHintCss:
- ".vimiumHintMarker {\n\n}\n" +
+ ".vimiumHintMarker \n/* linkhint boxes */ {\nbackground-color:yellow;\nborder:1px solid #E3BE23;\n}\n\n" +
+ ".vimiumHintMarker span \n/* linkhints text */ {\ncolor: black;\nfont-weight: bold;\nfont-size: 12px;\n}\n\n" +
".vimiumHintMarker > .matchingCharacter {\n\n}",
excludedUrls: "http*://mail.google.com/*\n" +
"http*://www.google.com/reader/*\n",
--
cgit v1.2.3
From 7745b49e9e90f043f4e494f1fe024cbd5b833de5 Mon Sep 17 00:00:00 2001
From: Peter Parks
Date: Tue, 1 Nov 2011 22:46:55 -0700
Subject: Defined margin as 0 on .vimiumHintMarker and .vimiumHUD to protect
against margin settings on the base div element by sites
---
background_page.html | 1 +
vimiumFrontend.js | 1 +
2 files changed, 2 insertions(+)
diff --git a/background_page.html b/background_page.html
index ada4b70c..73ffd77f 100644
--- a/background_page.html
+++ b/background_page.html
@@ -53,6 +53,7 @@
'position:absolute;' +
'background-color:yellow;' +
'padding:0 1px;' +
+ 'margin: 0;' +
'width:auto;' +
'display:block;' +
'border:1px solid #E3BE23;' +
diff --git a/vimiumFrontend.js b/vimiumFrontend.js
index 4ab01d2a..edc67709 100644
--- a/vimiumFrontend.js
+++ b/vimiumFrontend.js
@@ -796,6 +796,7 @@ HUD = {
"text-align: left;" +
"background-color: #ebebeb;" +
"padding: 3px 3px 2px 3px;" +
+ "margin: 0; " +
"border: 1px solid #b3b3b3;" +
"border-radius: 4px 4px 0 0;" +
"font-family: Lucida Grande, Arial, Sans;" +
--
cgit v1.2.3
From 44c36c6ab1c6111f25e535fabfd3b5c75fb4120e Mon Sep 17 00:00:00 2001
From: Peter Parks
Date: Wed, 2 Nov 2011 14:10:54 -0700
Subject: Adjusted CSS for linkhints, help menu, text search, and bookmarks
search UI elements. They should now be able to stand up to base element
declarations created by a website. Added comments to the linkhints css
settings on the options page and set default properties that a user would
change to make it clear where they should be modified. Added a dropshadow to
the linkhints to make them stand out better against similarly colored site
backgrounds.
---
background_page.html | 28 ++++++++++++++++++++++++++--
completionDialog.js | 26 ++++++++++++++++----------
helpDialog.html | 44 ++++++++++++++++++++++++++++++++++++++++++--
vimiumFrontend.js | 9 +++++++++
4 files changed, 93 insertions(+), 14 deletions(-)
diff --git a/background_page.html b/background_page.html
index 73ffd77f..7ba2471d 100644
--- a/background_page.html
+++ b/background_page.html
@@ -30,7 +30,7 @@
filterLinkHints: false,
userDefinedLinkHintCss:
".vimiumHintMarker \n/* linkhint boxes */ {\nbackground-color:yellow;\nborder:1px solid #E3BE23;\n}\n\n" +
- ".vimiumHintMarker span \n/* linkhints text */ {\ncolor: black;\nfont-weight: bold;\nfont-size: 12px;\n}\n\n" +
+ ".vimiumHintMarker span \n/* linkhint text */ {\ncolor: black;\nfont-weight: bold;\nfont-size: 12px;\n}\n\n" +
".vimiumHintMarker > .matchingCharacter {\n\n}",
excludedUrls: "http*://mail.google.com/*\n" +
"http*://www.google.com/reader/*\n",
@@ -55,27 +55,51 @@
'padding:0 1px;' +
'margin: 0;' +
'width:auto;' +
+ 'height:auto;' +
'display:block;' +
'border:1px solid #E3BE23;' +
+ 'opacity: 1;' +
'z-index:99999999;' +
'top:-1px;' +
'left:-1px;' +
- 'white-space:nowrap;' +
+ 'bottom: auto;' +
+ 'right: auto;' +
+ 'text-indent: 0;' +
+ // set font-size and line-height to ensure the box height adjust to the span height
+ 'font-size: 0px;' +
+ 'line-height: 100%;' +
+ // Add drop shadow in case the linkhint color is the same as the page color
+ 'box-shadow: rgba(0, 0, 0, 0.3) 2px 2px;' +
+ 'max-width: none;' +
+ 'min-width: 0;' +
+ 'max-height: none;' +
+ 'min-height: 0;' +
'}' +
'.internalVimiumHintMarker span {' +
'color: black;' +
+ 'opacity: 1;' +
'text-decoration: none;' +
'font-weight: bold;' +
'font-size: 12px;' +
+ 'font-size-adjust: normal;' +
'font-style: normal;' +
+ 'font-width: normal;' +
'letter-spacing: 0;' +
'text-transform: none;' +
'text-align: left;' +
'text-indent: 0;' +
+ 'text-shadow: none;' +
'line-height: 100%;' +
'font-family: "Helvetica Neue", "Helvetica", "Arial", "Sans";' +
'padding: 0;' +
'margin: 0;' +
+ 'width: auto;' +
+ 'height: auto;' +
+ 'min-height: 0;' +
+ 'max-height: none;' +
+ 'min-width: 0;' +
+ 'max-width: none;' +
+ 'display: inline;' +
'float: none;' +
'border: none;' +
'background: none;' +
diff --git a/completionDialog.js b/completionDialog.js
index f264eb2a..7a01a10d 100644
--- a/completionDialog.js
+++ b/completionDialog.js
@@ -149,30 +149,36 @@
"color: black;" +
"padding:10px;"+
"border-radius: 4px;" +
- "font-family: Lucida Grande, Arial, Sans;" +
"}"+
+
".vimium-completions {"+
- "width:400px;"+
+ "width:400px;"+
"}"+
+
".vimium-completions .vimium-searchBar {"+
- "height: 15px;"+
- "border-bottom: 1px solid #b3b3b3;"+
+ "height: 15px;"+
+ "border-bottom: 1px solid #b3b3b3;"+
"}"+
+
".vimium-completions .vimium-searchResults {"+
"}"+
+
".vimium-completions .vimium-searchResults .vimium-selected{"+
- "background-color:#aaa;"+
- "border-radius: 4px;" +
+ "background-color:#aaa;"+
+ "border-radius: 4px;" +
"}"+
+
".vimium-completions div{"+
- "padding:4px;"+
+ "padding:4px;"+
"}"+
+
".vimium-completions div strong{"+
- "color: black;" +
- "font-weight:bold;"+
+ "color: black;" +
+ "font-weight:bold;"+
"}"+
+
".vimium-completions .vimium-noResults{"+
- "color:#555;"+
+ "color:#555;"+
"}";
window.CompletionDialog = CompletionDialog;
diff --git a/helpDialog.html b/helpDialog.html
index aa534640..aae8b619 100644
--- a/helpDialog.html
+++ b/helpDialog.html
@@ -4,11 +4,46 @@
-->
-
-
Options
-
x
-
Vimium {{title}}
-
-
- | | Navigating the page |
+
+
Options
+
x
+
Vimium {{title}}
+
+
+
+ | | Navigating the page |
{{pageNavigation}}
+
-
-
- | | Using find |
+
+
+
+ | | Using find |
{{findCommands}}
- | | Navigating history |
+ | | Navigating history |
{{historyNavigation}}
- | | Manipulating tabs |
+ | | Manipulating tabs |
{{tabManipulation}}
- | | Miscellaneous |
+ | | Miscellaneous |
{{misc}}
+
-
+
-